Commit graph

1128 commits

Author SHA1 Message Date
Daniel Martí
3736da3761 No longer use universal_newlines
It was added in an attempt to get git clone/fetch output, which did not
succeed.
2014-04-17 20:47:13 +02:00
Daniel Martí
f79ded4a26 Also ignore .bzr when scanning 2014-04-16 21:06:24 +02:00
Daniel Martí
559ad9ef5b Also glob the 'rm' field 2014-04-15 23:58:12 +02:00
Daniel Martí
d4f9f341ed Glob scanignore and scandelete
These fields can still be used without globbing, but globbing can be very
useful in some cases.
2014-04-15 23:53:44 +02:00
Daniel Martí
8f0f896d91 Rewrite much of the source scanner
* Group apk, jar and zip files in the same case
* Use regex to support more patterns and be more flexible
* Only check for usual suspects in jar files (saves time)
* Also catch unknown zip-like files as warnings
2014-04-15 23:33:54 +02:00
Daniel Martí
b92b722c6d Fix: some apks have a zip mimetype instead of a jar one 2014-04-15 17:50:08 +02:00
Daniel Martí
5c483a5484 Fix apk path on gradle builds with many subdirs 2014-04-15 11:50:02 +02:00
Daniel Martí
5f2c348b40 Support gradle variables without an equals sign 2014-04-12 01:00:59 +02:00
Daniel Martí
67054c7c6f Fix counting of scanner problems 2014-04-12 00:18:20 +02:00
Ciaran Gultnieks
81e6fb8eb5 Point wiki current/history links to gitlab 2014-04-11 16:44:33 +01:00
Daniel Martí
f4ee767013 Fix Categories: default value 2014-04-10 17:27:53 +02:00
Ciaran Gultnieks
5b21f86af2 Add buildserver details to AndroidManifest.xml 2014-04-10 13:59:17 +01:00
Ciaran Gultnieks
f95eccf307 Put commit hash of fdroidserver in use onto buildserver 2014-04-10 13:58:42 +01:00
Ciaran Gultnieks
b7420192eb Support different identity file structures
Something to do with vagrant/paramiko versioning.
2014-04-10 13:57:16 +01:00
Ciaran Gultnieks
8fdfc47f84 Fix snapshot logging error 2014-04-10 13:56:45 +01:00
Daniel Martí
2f43d30884 Specify that scanner warnings are not counted 2014-04-08 18:49:59 +02:00
Hans-Christoph Steiner
0dd8116059 add note about automatically generated signing key after init 2014-04-07 16:00:18 -04:00
Hans-Christoph Steiner
00b89c05c5 warn user if smartcard keystore is set but opensc is not installed 2014-04-07 16:00:18 -04:00
Hans-Christoph Steiner
3829d37d34 support repo signing with a key on a smartcard
This assumes that the smartcard is already setup with a signing key.  init
does not generate a key on the smartcard, and skips genkey() if things are
configured to use a smartcard.

This also does not touch APK signing because that is a much more elaborate
question, since each app is signed by its own key.
2014-04-07 16:00:18 -04:00
Hans-Christoph Steiner
9945045f1b fix bug setting repo_keyalias in init 2014-04-07 16:00:18 -04:00
Hans-Christoph Steiner
f582cd7a9e fix bug listing new key created in init
Oops, a typo with a ] in e53092cffa
2014-04-07 16:00:18 -04:00
Hans-Christoph Steiner
b41f9e67a9 if keystore is given as arg to init, create keystore if it does not exist
Previously, `fdroid init --keystore /tmp/foo` expected the keystore to
exist, or it quit with an error.  But I've changed my mind, I think it is
useful to have it generate a new keystore at that location if it does not
exist.  For example, in tests/run-tests.sh. It still will not clobber an
existing file at that location.
2014-04-07 16:00:18 -04:00
Hans-Christoph Steiner
2bd62239f7 'smartcardoptions' config item for setting up HSMs with fdroid
These options are needed to configure Java's keytool and jarsigner to use
a Hardware Security Module aka HSM aka smartcard.  The defaults provided
are meant to make things work as easily as possible.
2014-04-07 16:00:18 -04:00
Hans-Christoph Steiner
0950cdac09 make repo_keyalias like a config option: leave it commented out
Before, the code relies on repo_keyalias being None, which does not feel
conffile-like.  Now, its commented out if its not set.
2014-04-07 16:00:18 -04:00
Hans-Christoph Steiner
f1ae3d3fd0 use default keystore path when generating a new setup with init
Before, the path to the keystore was also hardcoded in init.py, this makes
init now get it from the defaults set in common.py.
2014-04-07 16:00:17 -04:00
Hans-Christoph Steiner
0736367675 when generating config.py during init, uncomment changed options
The defaults are set in config.py and are often commented out.  Before, the
regex would only change the value, but leave it commented out.  Now, it
will also uncomment it.
2014-04-07 16:00:17 -04:00
Hans-Christoph Steiner
40fdc2a943 improved error messages related to missing/non-functional SDK paths 2014-04-07 16:00:17 -04:00
Ciaran Gultnieks
7f822b01bf Validate publish-related file existence before proceeding 2014-04-04 15:37:18 +01:00
Ciaran Gultnieks
e4ad174399 Use keystore options correctly
Corrects error in 525759b235
2014-04-04 15:31:07 +01:00
Ciaran Gultnieks
c353a69231 Switch back to paramiko for all modules 2014-04-03 17:14:59 +01:00
Daniel Martí
c08987cf4b Avoid printing the dir '' 2014-04-03 16:10:54 +02:00
Daniel Martí
fb933ebafd Make pylint happy about re-using the 'added' var 2014-04-03 16:05:15 +02:00
Daniel Martí
0c11f7bc49 scan_source: print problems, only return the total count 2014-04-03 16:04:06 +02:00
Daniel Martí
3905143252 Add default repotype() to make pylint happy 2014-04-02 23:37:29 +02:00
Daniel Martí
8e87feff26 Fix output naming, remove redundant lstrip() 2014-04-02 01:05:33 +02:00
Hans-Christoph Steiner
e53092cffa fix genkey key listing in fdroid init
FDroidPopen() does not have a way to send to stdin, so we will use the
password file for now.  In the long run, at least the keypass should always
be sent via stdin rather than via a file.  Ideally, storepass would be too,
but if they are different, then storepass is less important.
2014-04-01 18:04:36 -04:00
Hans-Christoph Steiner
ed3bd25bb5 oops, include common. to call write_password_file() 2014-04-01 18:04:36 -04:00
Hans-Christoph Steiner
8ef6546f81 move fdroid-icon.png to examples/ 2014-04-01 18:04:36 -04:00
Hans-Christoph Steiner
d21bddc159 improved warning when trying to init a dir with stuff in it 2014-04-01 17:51:54 -04:00
Daniel Martí
802d5e298c Merge commit 'refs/merge-requests/137' of gitorious.org:f-droid/fdroidserver 2014-04-01 23:47:11 +02:00
Daniel Martí
870ed87a36 Fix bankdroid build
All console stuff should be avoided already with just readLine
2014-04-01 19:29:37 +02:00
Daniel Martí
5dc29c8a05 Fix apk path on gradle builds where both subdir and flavour@dir are used 2014-04-01 19:25:43 +02:00
Daniel Martí
d8374b3efa Add keyaliases config default 2014-04-01 18:58:20 +02:00
Hans-Christoph Steiner
7bb490221a set the default keystore to the same as the default in fdroid init
This should keep things simple and consistent.
2014-03-31 21:42:46 -04:00
Hans-Christoph Steiner
a31f4571c2 fix example files install in setup.py
This also makes the file layout in git basically the same as the installed
file layout, using an examples/ dir.  I'm not sure if config.buildserver.py
is an example conf file, or a conf file that is actually in use, so I did
not move it.
2014-03-31 21:29:51 -04:00
Hans-Christoph Steiner
525759b235 stop passing passphrases via args, instead use prepared files
Any process can read the process table, and can therefore see the entire
command line of any other process.  That means its a bad idea to ever put
passwords as part of a command line.  Python is executing keytool and
jarsigner command lines here, so now instead of putting the password on the
command line, a file is passed instead with suitable file permissions.
This should reduce the exposure a lot.  But still, sensitive passwords
should not be written to any text file.

This change requires OpenJDK-7 since the :file option to -storepass and
-keypass was only added in Java 7's keytool and jarsigner.
2014-03-31 21:02:42 -04:00
Daniel Martí
caa88ec388 Fix indexing issue with recursive srclibs 2014-03-31 19:23:48 +02:00
Daniel Martí
214d63e48f Better identify empty licenses 2014-03-28 11:40:58 +01:00
Daniel Martí
edda052000 Error if buildjni= is present but no native code was packaged 2014-03-27 19:22:21 +01:00
Daniel Martí
25a8dd5af4 Start rewriting git@github submodues to use https 2014-03-27 18:38:12 +01:00