Commit graph

1128 commits

Author SHA1 Message Date
Hans-Christoph Steiner
c81ff764a3 update: improve warning about APKs set to be debuggable
This uses the actual XML code used to set this flag making the warning
message easily searchable on the interwebs.
2014-06-04 22:01:25 -04:00
Hans-Christoph Steiner
d68830418b apps with no <uses-sdk> get strange values of minSdkVersion
Using this example app which does not have <uses-sdk>:
https://android.googlesource.com/platform/development/+log/master/samples/ApiDemos/assets/HelloActivity.apk

aapt then returns "sdkVersion:'IceCreamSandwich'".  minSdkVersion is only
ever supposed to be an integer, so this is a bizarre APK.  It is included
only as a binary in the git repo for Android sample code.  But who knows
what else is out there, so report and error and carry on with the update
process.
2014-06-04 22:01:25 -04:00
Hans-Christoph Steiner
57a4e03277 update: skip APKs that cannot be parsed instead of exiting
Some APKs can be corrupt or some system APKs do not have all the normal
info.  Instead of quitting, `fdroid update` skips the non-parsable APKs and
optionally deletes them if --delete-unknown is specified.
2014-06-04 22:01:25 -04:00
Hans-Christoph Steiner
ed73db65ae make FDroidPopen output based on --verbose
FDroidPopen outputs by default, this should be controlled by the --verbose
flag so that most of the time, only meaningful messages are shown like
errors and such.  For command output that should be shown everytime,
output=True can be set.
2014-06-04 22:01:25 -04:00
Hans-Christoph Steiner
c6d946ed54 update: remove overly verbose message about icon sizing being correct
This seems like purely a debug message, I can't see why its useful in general
2014-06-04 22:01:25 -04:00
Hans-Christoph Steiner
78d5ebf26c use 'metadata' name throughout: --createmeta to --create-metadata
To keep the naming used within fdroid consistent, I renamed this long flag
to use the whole word 'metadata' since that is what is used everywhere else
2014-06-04 21:54:56 -04:00
Hans-Christoph Steiner
bc8ad37249 init: make prompt for SDK path exit cleanly on Ctrl-C
This just makes a clean exit rather than showing a python stacktrace.
2014-06-04 21:54:55 -04:00
Hans-Christoph Steiner
6ca060e10d add more SDK checks: build-tools/19.0.3 and presense of aapt
Make sure that fdroid can find aapt in the current config, otherwise exit
with an error.  Some users don't have build_tools set, and their SDK does
not include the build-tools in the default versioned dir, so this should
warn them of what is wrong.
2014-06-04 21:54:55 -04:00
Daniel Martí
3690b89e0a Fix crash in checkupdates with auto-updates 2014-06-04 13:29:01 +02:00
Daniel Martí
9198cd4127 Add warnings for repo clonings in build recipes 2014-06-01 19:12:00 +02:00
Daniel Martí
67cbd1fba4 Fix the script defaults 2014-06-01 19:11:49 +02:00
Daniel Martí
9f1c075119 No need to check for non-default build items 2014-06-01 19:05:18 +02:00
Daniel Martí
8fd02e3fcf Remove dead mvnflags code 2014-06-01 19:05:10 +02:00
Daniel Martí
8675d50261 Add support for gitlab.com repos to import 2014-06-01 16:37:33 +02:00
Daniel Martí
67630b6c72 Store build comments by vercode, not version
vercodes are unique, versions aren't
2014-06-01 15:40:33 +02:00
Daniel Martí
a544907bef Don't allow for duplicate build entries 2014-06-01 15:38:11 +02:00
Daniel Martí
3d72c30fe5 Use ordered dicts for defaults in apps and builds 2014-05-31 23:54:50 +02:00
Daniel Martí
b594558811 Re-order app_defaults to match the writing order
Also fix a couple of issues:

* Update Check Name was never written to disk
* Maintainer Notes had no default and was used differently
2014-05-30 19:51:10 +02:00
Daniel Martí
e93017569f Simplify field/flag checking and bool flag usage 2014-05-30 18:52:30 +02:00
Daniel Martí
5933880a90 Make unspecified license use regex 2014-05-30 18:52:30 +02:00
Hans-Christoph Steiner
6839f9a9ed fixes #12: make fdroid update -c do complete update like fdroid update
Since the new metadata created by -c is added after the existing metadata
was already parsed, `fdroid update -c` was not doing a complete update of
the repo.  This moves the metadata creation as early as possible, then
reruns the metadata parsing if new metadata was created.

refs #12 https://gitlab.com/fdroid/fdroidserver/issues/12
2014-05-29 15:29:57 -04:00
Hans-Christoph Steiner
af22962572 Fixes #8: if unknown APKs found, prompt to use -c or use --delete-unknown
This adds the option --delete-unknown for the current default behavior of
`fdroid update`: to delete any unknown APKs.  Instead, it just outputs a
warning about the unknown APKs and suggests -c for adding it.

Fixes #8 https://gitlab.com/fdroid/fdroidserver/issues/8
2014-05-29 13:40:06 -04:00
Hans-Christoph Steiner
2f3022ff65 fix PEP8 E128 continuation line under-indented for visual indent 2014-05-29 13:10:28 -04:00
Daniel Martí
0f0ccdb1e1 Fix some more pep8 warnings 2014-05-28 09:33:14 +02:00
Daniel Martí
1d5280d528 Fix pyflakes errors in readmeta 2014-05-27 15:56:57 +02:00
Daniel Martí
ecb2a2a969 Make readmeta use srclibs and check for config.py too 2014-05-27 15:17:37 +02:00
Daniel Martí
9301c50e3b More strict string search regex 2014-05-27 10:10:15 +02:00
Daniel Martí
5bbbda71a3 Also use srclibs in checkupdates
Needed when Repo Type is srclib
2014-05-27 09:53:58 +02:00
Daniel Martí
a129ef5f9f Warn about summaries that are not capitalized 2014-05-26 08:09:22 +02:00
Daniel Martí
93a56e4f51 Fall back to launchable-activity label if application has none
This fixes apps like MiniZip not having a name
2014-05-23 09:47:11 +02:00
Ciaran Gultnieks
3a73654d49 Centralise management of srclib metadata 2014-05-20 22:44:47 +01:00
Ciaran Gultnieks
e29da6b023 Restore friendly error messages
Use --verbose if you really want a full traceback with your 'you made a
typo in an package ID' messages.

It would be better to do this based on exception types (i.e. our own
exceptions - MetadataException, BuildException, VCSException) would not
print a traceback, but unexpected exceptions would. But the types are
not available at the 'fdroid' level currently.
2014-05-20 22:14:19 +01:00
Ciaran Gultnieks
6391f204e1 Lose the other unused read_metadata parameter 2014-05-20 21:07:54 +01:00
Ciaran Gultnieks
720ec22e9a Remove mysterious keyword arguments 2014-05-20 17:55:48 +01:00
Ciaran Gultnieks
277d95f57d Fix several read_metadata-related issues
Various calls with the wrong parameters, and also an unused parameter on
the function itself.
2014-05-20 17:48:45 +01:00
Daniel Martí
a36865e9b1 lint: warn about empty descriptions
If some app has the default description because it's not going to be published
or will never have a working build, the whole app should be disabled.
2014-05-16 13:04:31 +02:00
Ciaran Gultnieks
d104f2e1fb Support https://code.google.com in fdroid import 2014-05-15 10:26:35 +01:00
Ciaran Gultnieks
0113f85448 Add ability to ignore updates based on version name matching 2014-05-13 20:04:22 +01:00
Ciaran Gultnieks
751daf0cda Fix too long lines in publish 2014-05-12 23:01:53 +01:00
Ciaran Gultnieks
b18d1b422e Remove excess usage description from gpgsign 2014-05-12 23:00:20 +01:00
Ciaran Gultnieks
d69b7ce338 Remove unused imports 2014-05-12 22:58:54 +01:00
Ciaran Gultnieks
f8cc84282e Correct logging output for gpgsign when already signed 2014-05-12 22:57:23 +01:00
Ciaran Gultnieks
ffdebd9516 Add 'fdroid gpgsign' command
Creates detached gpg signatures for any apks that don't have them
yet. Relevant configuration fields need to be set first.
2014-05-12 21:57:09 +01:00
Ciaran Gultnieks
cf1201833b Add proprietary samsung jar to usual suspects 2014-05-11 22:14:32 +01:00
Daniel Martí
17a4f5c00f A few more PEP8 fixes 2014-05-07 16:17:46 +02:00
Hans-Christoph Steiner
37d6d87ff7 fix PEP8 "E226 missing whitespace around arithmetic operator" 2014-05-06 14:36:33 -04:00
Hans-Christoph Steiner
0e00b36db5 fix PEP8 E124/E125/126/127/128 indentation issues
* E124 closing bracket does not match visual indentation
* E125 continuation line does not distinguish itself from next logical line
* E126 continuation line over-indented for hanging indent
* E127 continuation line over-indented for visual indent
* E128 continuation line under-indented for visual indent
2014-05-06 14:36:33 -04:00
Hans-Christoph Steiner
6abb390547 fix PEP8 "E261 at least two spaces before inline comment" 2014-05-06 11:45:04 -04:00
Hans-Christoph Steiner
aa5f317c26 fix PEP8 "W391 blank line at end of file" 2014-05-06 11:45:03 -04:00
Hans-Christoph Steiner
16dc3b27d6 fix PEP8 "E303 too many blank lines (2)" 2014-05-06 11:45:03 -04:00