mirrors/v
1
0
Fork 0
mirror of https://github.com/vlang/v.git synced 2025-09-13 14:32:26 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions 13

builtin: improve multi-platform portability for string.split_into_lines() (#17078)

Browse source
This commit is contained in:
Roy Ivy III 2023-01-24 02:02:25 -06:00 • committed by GitHub
parent 0230395062
commit 5cd074a49e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 75 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

26
vlib/builtin/string.v
View file

@ -841,22 +841,34 @@ pub fn (s string) split_nth(delim string, nth int) []string {
// split_into_lines splits the string by newline characters.
// newlines are stripped.
// Both `\n` and `\r\n` newline endings are supported.
// `\r` (MacOS), `\n` (POSIX), and `\r\n` (WinOS) line endings are all supported (including mixed line endings).
// NOTE: algorithm is "greedy", consuming '\r\n' as a single line ending with higher priority than '\r' and '\n' as multiple endings
[direct_array_access]
pub fn (s string) split_into_lines() []string {
mut res := []string{}
if s.len == 0 {
return res
}
mut start := 0
cr := `\r`
lf := `\n`
mut line_start := 0
for i := 0; i < s.len; i++ {
if s[i] == 10 {
res << if start == i { '' } else { s[start..i].trim_right('\r') }
start = i + 1
if line_start <= i {
if s[i] == lf {
res << if line_start == i { '' } else { s[line_start..i] }
line_start = i + 1
} else if s[i] == cr {
res << if line_start == i { '' } else { s[line_start..i] }
if ((i + 1) < s.len) && (s[i + 1] == lf) {
line_start = i + 2
} else {
line_start = i + 1
}
}
}
}
if start < s.len {
res << s[start..]
if line_start < s.len {
res << s[line_start..]
}
return res
}