mirrors/v
1
0
Fork 0
mirror of https://github.com/vlang/v.git synced 2025-09-13 22:42:26 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions 13

testing: retry 1 additional time sporadic silent test run failures on macos

Browse source
This commit is contained in:
Delyan Angelov 2024-01-23 23:30:10 +02:00
parent 712d4a0a6b
commit 22e0b984d4
No known key found for this signature in database
GPG key ID: 66886C0F12D595ED
1 changed files with 14 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

21
cmd/tools/modules/testing/common.v
View file

@ -626,6 +626,7 @@ fn worker_trunner(mut p pool.PoolProcessor, idx int, thread_id int) voidptr {
} }
} }
// //
mut retry := 1
ts.append_message(.cmd_begin, run_cmd, mtc) ts.append_message(.cmd_begin, run_cmd, mtc)
mut failure_output := strings.new_builder(1024) mut failure_output := strings.new_builder(1024)
d_cmd := time.new_stopwatch() d_cmd := time.new_stopwatch()
@ -633,12 +634,17 @@ fn worker_trunner(mut p pool.PoolProcessor, idx int, thread_id int) voidptr {
cmd_duration = d_cmd.elapsed() cmd_duration = d_cmd.elapsed()
ts.append_message_with_duration(.cmd_end, r.output, cmd_duration, mtc) ts.append_message_with_duration(.cmd_end, r.output, cmd_duration, mtc)
if r.exit_code != 0 { if r.exit_code != 0 {
mut details := get_test_details(file)
mut trimmed_output := r.output.trim_space()
if trimmed_output.len == 0 {
// retry running at least 1 more time, to avoid CI false positives as much as possible
details.retry++
}
failure_output.write_string(testing.separator) failure_output.write_string(testing.separator)
failure_output.writeln(' retry: 0') failure_output.writeln(' retry: 0 ; max_retry: ${details.retry} ; r.exit_code: ${r.exit_code} ; trimmed_output.len: ${trimmed_output.len}')
failure_output.writeln(r.output.trim_space()) failure_output.writeln(trimmed_output)
details := get_test_details(file)
os.setenv('VTEST_RETRY_MAX', '${details.retry}', true) os.setenv('VTEST_RETRY_MAX', '${details.retry}', true)
for retry := 1; retry <= details.retry; retry++ { for retry = 1; retry <= details.retry; retry++ {
ts.append_message(.info, ' retrying ${retry}/${details.retry} of ${relative_file} ; known flaky: ${details.flaky} ...', ts.append_message(.info, ' retrying ${retry}/${details.retry} of ${relative_file} ; known flaky: ${details.flaky} ...',
mtc) mtc)
os.setenv('VTEST_RETRY', '${retry}', true) os.setenv('VTEST_RETRY', '${retry}', true)
@ -654,9 +660,10 @@ fn worker_trunner(mut p pool.PoolProcessor, idx int, thread_id int) voidptr {
goto test_passed_execute goto test_passed_execute
} }
} }
trimmed_output = r.output.trim_space()
failure_output.write_string(testing.separator) failure_output.write_string(testing.separator)
failure_output.writeln(' retry: ${retry}') failure_output.writeln(' retry: ${retry} ; max_retry: ${details.retry} ; r.exit_code: ${r.exit_code} ; trimmed_output.len: ${trimmed_output.len}')
failure_output.writeln(r.output.trim_space()) failure_output.writeln(trimmed_output)
time.sleep(testing.fail_retry_delay_ms) time.sleep(testing.fail_retry_delay_ms)
} }
full_failure_output := failure_output.str().trim_space() full_failure_output := failure_output.str().trim_space()
@ -671,7 +678,7 @@ fn worker_trunner(mut p pool.PoolProcessor, idx int, thread_id int) voidptr {
tls_bench.fail() tls_bench.fail()
cmd_duration = d_cmd.elapsed() - (testing.fail_retry_delay_ms * details.retry) cmd_duration = d_cmd.elapsed() - (testing.fail_retry_delay_ms * details.retry)
ts.append_message_with_duration(.fail, tls_bench.step_message_with_label_and_duration(benchmark.b_fail, ts.append_message_with_duration(.fail, tls_bench.step_message_with_label_and_duration(benchmark.b_fail,
'${normalised_relative_file}\n comp_cmd: ${cmd}\n run_cmd: ${run_cmd}\nfailure output:\n${full_failure_output}', '${normalised_relative_file}\n retry: ${retry}\n comp_cmd: ${cmd}\n run_cmd: ${run_cmd}\nfailure code: ${r.exit_code}; foutput.len: ${full_failure_output.len}; failure output:\n${full_failure_output}',
cmd_duration, cmd_duration,
preparation: compile_cmd_duration preparation: compile_cmd_duration
), cmd_duration, mtc) ), cmd_duration, mtc)