mirrors/v
1
0
Fork 0
mirror of https://github.com/vlang/v.git synced 2025-09-13 22:42:26 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions 13

checker: add more checks for map.delete

Browse source
This commit is contained in:
Swastik 2025-08-31 02:43:35 +05:30
parent 283c81fd64
commit 17f21c46ac
3 changed files with 30 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

7
vlib/v/checker/fn.v
View file

@ -3213,14 +3213,15 @@ fn (mut c Checker) map_builtin_method_call(mut node ast.CallExpr, left_type_ ast
} }
'delete' { 'delete' {
c.check_for_mut_receiver(mut node.left) c.check_for_mut_receiver(mut node.left)
if node.args.len != 1 { if node.args.len == 1 {
c.error('expected 1 argument, but got ${node.args.len}', node.pos)
}
info := left_sym.info as ast.Map info := left_sym.info as ast.Map
arg_type := c.expr(mut node.args[0].expr) arg_type := c.expr(mut node.args[0].expr)
c.check_expected_call_arg(arg_type, info.key_type, node.language, node.args[0]) or { c.check_expected_call_arg(arg_type, info.key_type, node.language, node.args[0]) or {
c.error('${err.msg()} in argument 1 to `Map.delete`', node.args[0].pos) c.error('${err.msg()} in argument 1 to `Map.delete`', node.args[0].pos)
} }
} else {
c.error('expected 1 argument, but got ${node.args.len}', node.pos)
}
} }
else {} else {}
} }

29
vlib/v/checker/tests/map_delete.out
View file

@ -12,16 +12,29 @@ vlib/v/checker/tests/map_delete.vv:6:4: error: expected 1 argument, but got 2
| ~~~~~~~~~~~~ | ~~~~~~~~~~~~
7 | m2 := { 7 | m2 := {
8 | '1': 1 8 | '1': 1
vlib/v/checker/tests/map_delete.vv:6:11: error: cannot use `int literal` as `string` in argument 1 to `Map.delete`
4 | }
5 | m.delete(1)
6 | m.delete(1, 2)
| ^
7 | m2 := {
8 | '1': 1
vlib/v/checker/tests/map_delete.vv:10:2: error: `m2` is immutable, declare it with `mut` to make it mutable vlib/v/checker/tests/map_delete.vv:10:2: error: `m2` is immutable, declare it with `mut` to make it mutable
8 | '1': 1 8 | '1': 1
9 | } 9 | }
10 | m2.delete('1') 10 | m2.delete('1')
| ~~ | ~~
11 | } 11 | m.delete()
12 | _ := m.delete()
vlib/v/checker/tests/map_delete.vv:11:4: error: expected 1 argument, but got 0
9 | }
10 | m2.delete('1')
11 | m.delete()
| ~~~~~~~~
12 | _ := m.delete()
13 | }
vlib/v/checker/tests/map_delete.vv:12:9: error: expected 1 argument, but got 0
10 | m2.delete('1')
11 | m.delete()
12 | _ := m.delete()
| ~~~~~~~~
13 | }
vlib/v/checker/tests/map_delete.vv:12:4: error: assignment mismatch: 1 variable but `delete()` returns 0 values
10 | m2.delete('1')
11 | m.delete()
12 | _ := m.delete()
| ~~
13 | }

2
vlib/v/checker/tests/map_delete.vv
View file

@ -8,4 +8,6 @@ fn main() {
'1': 1 '1': 1
} }
m2.delete('1') m2.delete('1')
m.delete()
_ := m.delete()
} }