Commit graph

172 commits

Author SHA1 Message Date
Daniel Martí
df9b044a3b lint: add dumb support for multiline links 2015-09-11 22:40:16 -07:00
Daniel Martí
b9b4880b49 lint: move regex closer to usage 2015-09-11 22:07:51 -07:00
Daniel Martí
e6b14c8995 lint: remove now obsolete description checks 2015-09-11 21:54:39 -07:00
Daniel Martí
cc48d2828c lint: overhaul, cleaner and saner output 2015-09-10 18:41:10 -07:00
Daniel Martí
acfc48970d lint: move lastbuild into separate function 2015-09-10 17:55:09 -07:00
Daniel Martí
a5c2e503b2 lint: remove "no recommended build" check
In some cases we do want to not recommend any version. The client should more
or less gracefully handle this.
2015-09-10 17:54:41 -07:00
Daniel Martí
e9e2713cde lint: cleanup, remove stale sites 2015-09-10 17:05:13 -07:00
Daniel Martí
9489e80f09 Merge branch 'replace_optparse_with_argparse' into 'master'
replace deprecated optparse with argparse

squashed and rebased merge request fdroid/fdroidserver!74

following guidelines from:
https://docs.python.org/2/library/argparse.html#upgrading-optparse-code
except, still using option = parse.parse_args() instead of args = ...

- using the following script in folder fdroidserver:
	```
	for i in *.py; do
		sed -i -e 's/optparse/argparse/' \
			-e 's/OptionParser/ArgumentParser/' \
			-e 's/OptionError/ArgumentError/' \
			-e 's/add_option/add_argument/' \
			-e 's/(options, args) = parser/options = parser/' \
			-e 's/options, args = parser/options = parser/' \
			-e 's/Usage: %prog/%(prog)s/' $i;
	done
	```
- use ArgumentParser argument to replace (option, args) = parser.parse()
  call
- use parser.error(msg) instead of raise ArgumentException as suggested
  in https://docs.python.org/2/library/argparse.html#exiting-methods
- in fdroid catch ArgumentError instead of OptionError

See merge request !75
2015-09-10 02:08:24 +00:00
Daniel Martí
29dea4aad5 lint: Warn about links left off from old sites 2015-09-08 13:33:43 -07:00
nero-tux
d23ecf1b35 replace deprecated optparse with argparse
following guidelines from:
https://docs.python.org/2/library/argparse.html#upgrading-optparse-code
except, still using option = parse.parse_args() instead of args = ...

- using the following script in folder fdroidserver:
	for i in *.py; do
		sed -i -e 's/optparse/argparse/' \
			-e 's/OptionParser/ArgumentParser/' \
			-e 's/OptionError/ArgumentError/' \
			-e 's/add_option/add_argument/' \
			-e 's/(options, args) = parser/options = parser/' \
			-e 's/options, args = parser/options = parser/' \
			-e 's/Usage: %prog/%(prog)s/' $i;
	done
- use ArgumentParser argument to replace (option, args) = parser.parse()
  call
- use parser.error(msg) instead of raise ArgumentException as suggested
  in https://docs.python.org/2/library/argparse.html#exiting-methods
- in fdroid catch ArgumentError instead of OptionError
2015-09-06 10:34:50 +02:00
Daniel Martí
3bc0d43786 lint: fixed list false positives, no need for utf 2015-08-31 15:39:07 -07:00
Daniel Martí
19a281d7cb lint: warn about duplicate lines 2015-08-31 15:32:52 -07:00
Daniel Martí
23794446f7 lint: catch more incorrect lists 2015-08-31 15:25:41 -07:00
Daniel Martí
12926420a6 lint: stop accepting Office as valid category 2015-08-30 16:29:03 -07:00
Daniel Martí
18fe72bb0d lint: accept new category Sports & Health 2015-08-30 16:08:22 -07:00
Daniel Martí
9d75b130bc lint: accept all new categories 2015-08-29 18:37:08 -07:00
Daniel Martí
d83d0c2520 lint: new category 2015-08-29 18:24:18 -07:00
Daniel Martí
3a331c5be1 lint: Wallpaper is now called Theming 2015-08-29 17:56:45 -07:00
Daniel Martí
518ba10b9f lint: remove Children as valid category 2015-08-29 17:52:15 -07:00
Daniel Martí
925fbee3b9 lint: complain about unwrapped descriptions 2015-08-28 19:05:47 -07:00
Daniel Martí
a4236d62cd lint: better footer output logic 2015-08-28 15:53:10 -07:00
Daniel Martí
ce8f74c98e lint: warn about unlinkified links 2015-08-28 15:50:34 -07:00
Daniel Martí
2c52f67cb1 lint: complain if link url isn't a url
Moving this check from metadata into lint is perhaps overkill, but at least it
doesn't break fdroid update because of the maintainer notes.
2015-08-28 14:23:30 -07:00
Daniel Martí
e4219dd438 lint: format descriptions too
Like readmeta. This makes it error if any links are badly formatted or wrong.
2015-08-28 11:09:37 -07:00
Daniel Martí
41b716ed7a Also force https on bitbucket 2015-08-26 18:57:13 -07:00
Daniel Martí
34f06dff24 Don't use lint to warn about google code
There are just too many. There is a script in fdroiddata to find google code
repos that have moved to github.
2015-08-26 18:35:50 -07:00
Daniel Martí
e88816bbe3 lint: warn about /master/ usage 2015-08-24 16:34:39 -07:00
Daniel Martí
41fd1e86af lint: also do http warnings on descriptions 2015-08-18 18:14:48 -07:00
Daniel Martí
80371da133 lint: better type safety 2015-08-18 18:07:01 -07:00
Daniel Martí
d0559f864e Warn about url shorteners being used 2015-08-18 17:54:32 -07:00
Daniel Martí
b9397733c3 Warn about misplaced flattr donation links 2015-08-18 17:53:56 -07:00
Daniel Martí
261ed09d7c lint: Update Check Name with unchanged app id 2015-08-18 14:01:14 -07:00
Daniel Martí
ab6d6a3d0b Also enforce https on urls without path 2015-08-14 15:30:03 -07:00
Daniel Martí
712c3aaae9 lint: warn about CVCs that don't make sense 2015-08-14 14:16:43 -07:00
Daniel Martí
e5bc581d0d lint: Fix unicode issues in list warnings 2015-08-13 22:37:42 -07:00
Daniel Martí
12fc0640df lint: don't warn multiple times about lists 2015-08-13 22:14:59 -07:00
Daniel Martí
fbff41234f lint: warn about incorrect lists 2015-08-13 22:13:58 -07:00
Daniel Martí
9fc583289e lint: complain about UCMs that haven't been used
Mainly for MRs from people who don't fill the automatic fields
2015-08-05 10:52:53 -07:00
Daniel Martí
fd6e323ba9 lint: exit with an error code if any errors are found 2015-07-30 12:46:42 -07:00
Daniel Martí
1fa9ec60a1 lint: start warning about invalid categories 2015-06-17 19:55:30 +02:00
Daniel Martí
5af099eb08 lint: take forcevercode into account for UCM warnings 2015-06-07 14:14:56 +02:00
Daniel Martí
d0a10e05d9 lint: get rid of -p/--pedantic
Only one check was left, and it's of little use anyway.
2015-06-07 14:05:29 +02:00
Daniel Martí
5f894f1d38 lint: complain about useless Name: fields 2015-06-07 14:03:15 +02:00
Daniel Martí
f9b7a260af lint: Move the UCM:Tags warning out of pedantic
It's much more reliable now
2015-06-05 17:15:13 +02:00
Daniel Martí
a8ec149cd4 lint: Improve UCM:Tags warning
If the vercode is higher than CVC, then we're probably only following stable
versions or something like that
2015-06-05 17:04:05 +02:00
Daniel Martí
7e529c495e lint: don't be pedantic about downloading code
We don't really control this if run via a script, which happens more often.
2015-06-05 16:59:01 +02:00
Daniel Martí
c70e03f67c lint: don't assume trailing slashes in urls are redundant 2015-06-05 16:56:51 +02:00
Daniel Martí
2231e72812 Remove now unnecessary regex_pedantic 2015-06-04 15:49:00 +02:00
Daniel Martí
56c855c6b1 lint: enforce https on gitlab too 2015-06-04 15:47:25 +02:00
Daniel Martí
46adf486c9 lint: Remove duplicate code.google.com TODO 2015-06-04 15:46:54 +02:00