Commit graph

159 commits

Author SHA1 Message Date
Daniel Martí
d1d257bef4 lint: add commented out warnings about google code 2015-04-14 14:18:44 +02:00
Daniel Martí
fdb71e2a41 lint: don't take commas as punctuation 2015-03-05 15:32:45 +01:00
Daniel Martí
3b7b8b9bde Don't take placeholders commits as possible tags 2015-03-05 15:25:21 +01:00
Boris Kraut
b1ec8cc47a Add "Changelog:" metadata field. 2015-01-11 02:26:41 +01:00
Daniel Martí
14f654fabc Apply some autopep8-python2 suggestions 2014-12-31 16:44:06 +01:00
Daniel Martí
3662dfd145 lint: warn (pedantic) about potentially dangerous auto updates 2014-12-22 18:18:07 +01:00
Daniel Martí
fe0af55a6a lint: find the current build like checkupdates does 2014-12-22 18:17:29 +01:00
Daniel Martí
5df1d89c8e Make lint report total app counts as well 2014-10-24 22:24:11 +02:00
Daniel Martí
ed9564023f Use '\s' instead of ' ' to identify spaces in regex 2014-10-15 15:00:45 +02:00
Daniel Martí
f90ba4747f Make lint check for trailing spaces 2014-10-15 14:36:59 +02:00
Daniel Martí
27edbd56a7 Discard descriptions longer than one line when checking duplicates 2014-09-01 10:34:12 +02:00
Daniel Martí
298934afa5 lint: warn about redundant links too 2014-08-26 13:33:17 +02:00
Daniel Martí
0da8c2c365 lint: fix duplicate usage of appid 2014-08-26 13:33:17 +02:00
Daniel Martí
96f49f2a9e lint: Also warn about descriptions that are just the summary 2014-08-25 00:41:25 +02:00
Daniel Martí
3d1213b602 lint: remove pedantic warnings that are often wrong 2014-08-25 00:41:01 +02:00
Daniel Martí
858c1eabc1 Add lint warning for empty summaries 2014-08-25 00:28:40 +02:00
Daniel Martí
94c29f9c37 Map apps in memory from appid to appinfo
Instead of storing them in a list and doing linear searches by appinfo['id']
2014-08-16 12:46:02 +02:00
Daniel Martí
2845cb56cc Also warn about HEAD, ignore disabled builds 2014-08-15 12:29:03 +02:00
Daniel Martí
78ff22d952 Drop svn support in favour of git-svn
Reasons:

* Cloning a svn repo via svn doesn't fetch the entire history
* Svn checkout is incredibly slow
* Svn doesn't have important features such as a 'clean' command

The only reason why we kept svn was for anonymous logins to repositories. This
is no longer a reason since git-svn also supports them.
2014-07-18 12:39:24 +02:00
Daniel Martí
8249324a7b Use counters in lint 2014-07-05 14:04:51 +02:00
Daniel Martí
3dbf99a7f2 Use shorter and non-redundant 'or' clauses for 'if True else' assignments 2014-07-03 17:35:28 +02:00
Daniel Martí
0c8512ca26 Install and lint were missing -q 2014-06-12 21:48:45 +02:00
Daniel Martí
9198cd4127 Add warnings for repo clonings in build recipes 2014-06-01 19:12:00 +02:00
Daniel Martí
3d72c30fe5 Use ordered dicts for defaults in apps and builds 2014-05-31 23:54:50 +02:00
Daniel Martí
5933880a90 Make unspecified license use regex 2014-05-30 18:52:30 +02:00
Daniel Martí
a129ef5f9f Warn about summaries that are not capitalized 2014-05-26 08:09:22 +02:00
Daniel Martí
a36865e9b1 lint: warn about empty descriptions
If some app has the default description because it's not going to be published
or will never have a working build, the whole app should be disabled.
2014-05-16 13:04:31 +02:00
Hans-Christoph Steiner
0e00b36db5 fix PEP8 E124/E125/126/127/128 indentation issues
* E124 closing bracket does not match visual indentation
* E125 continuation line does not distinguish itself from next logical line
* E126 continuation line over-indented for hanging indent
* E127 continuation line over-indented for visual indent
* E128 continuation line under-indented for visual indent
2014-05-06 14:36:33 -04:00
Hans-Christoph Steiner
aa5f317c26 fix PEP8 "W391 blank line at end of file" 2014-05-06 11:45:03 -04:00
Hans-Christoph Steiner
3f4f7a544b fix PEP8 "E302 expected 2 blank lines, found 1" 2014-05-06 11:45:03 -04:00
Hans-Christoph Steiner
2f2618e06c fix PEP8 "E401 multiple imports on one line" 2014-05-06 11:45:03 -04:00
Hans-Christoph Steiner
998011d535 fix PEP8 "E231 missing whitespace after ','" 2014-05-06 11:45:02 -04:00
Daniel Martí
42bfe13be4 Also pre-compile list regex warnings 2014-05-06 16:08:53 +02:00
Daniel Martí
65205a6ec3 Warn about leading spaces in descriptions 2014-05-06 16:08:53 +02:00
Daniel Martí
4592cece2f Slightly better summary/name warning message 2014-04-27 14:14:49 +02:00
Daniel Martí
2f3a92cd29 Count warnings and apps in lint 2014-04-18 21:17:06 +02:00
Daniel Martí
6d8dd4bed2 Add summary-related lint warnings 2014-04-18 20:54:44 +02:00
Daniel Martí
214d63e48f Better identify empty licenses 2014-03-28 11:40:58 +01:00
Daniel Martí
65d796c93a Only make lists if a space follows the # or * sign
This prevents making a list item out of lines such as:

*.rom images and allows using...
2014-03-27 17:51:34 +01:00
Daniel Martí
eee7f8b4f6 Avoid some false positives in the punctuation check 2014-03-24 01:02:11 +01:00
Daniel Martí
b94a772ad9 Print version names and srclibs for reference 2014-03-18 12:46:40 +01:00
Daniel Martí
03975808a3 A couple more rules for lint 2014-03-18 12:26:24 +01:00
Daniel Martí
d5c62d3bbd Separate lint messages into warnings and pedantic warnings 2014-03-18 12:20:40 +01:00
Daniel Martí
a49f04a947 Minor fixes to lint.py 2014-02-14 23:59:39 +01:00
Hans-Christoph Steiner
b706ec986f lint.py: add checks for https:// in various URLs
Many times, the http:// URL automatically redirects to https://, like with
github and gitorious.  For git repos, using https:// reduces metadata
leakage for more privacy, and increases the security a little bit.  For SVN
repos, using https:// is much more important since the repo format itself
does not provide the same level of verification as git, hg, etc. do.
2014-02-12 22:43:27 -05:00
Daniel Martí
2f93ba9bd6 Merge branch 'master' into logging
Conflicts:
	fdroidserver/common.py
2014-01-28 14:14:59 +01:00
Daniel Martí
3687147997 Update my own copyright notices 2014-01-28 14:07:19 +01:00
Daniel Martí
1e3c2eee25 More logging switching 2014-01-27 21:49:29 +01:00
Daniel Martí
cb11826929 Lint: don't complain if using tags and UCM is RM/branch 2014-01-26 20:42:47 +01:00
Daniel Martí
6855b6c442 Don't warn about tags UCM usage if UCM:None 2014-01-24 18:25:06 +01:00