From ff1638c7dc497d9b79c384d5cf15ca557f71b459 Mon Sep 17 00:00:00 2001
From: Hans-Christoph Steiner <hans@eds.org>
Date: Tue, 9 Mar 2021 12:07:24 +0100
Subject: [PATCH] scanner: show error if scan_binary fails to run apkanalyzer

---
 fdroidserver/scanner.py | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/fdroidserver/scanner.py b/fdroidserver/scanner.py
index 8699b8c0..239e82b4 100644
--- a/fdroidserver/scanner.py
+++ b/fdroidserver/scanner.py
@@ -106,6 +106,9 @@ def scan_binary(apkfile):
     logging.info("Scanning APK for known non-free classes.")
     result = common.SdkToolsPopen(["apkanalyzer", "dex", "packages", "--defined-only", apkfile], output=False)
     problems = 0
+    if result.returncode != 0:
+        problems += 1
+        logging.error(result.output)
     for suspect, regexp in CODE_SIGNATURES.items():
         matches = regexp.findall(result.output)
         if matches: