mirrors/fdroidserver
1
0
Fork 0
mirror of https://github.com/f-droid/fdroidserver.git synced 2025-11-08 16:30:28 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

Don't use generic Exception raises

Browse source 
That hides bugs, since all exceptions (including bugs that cause raises that
weren't our doing) fall under the "Exception" except
This commit is contained in:
Daniel Martí 2014-07-07 15:41:32 +02:00
parent b56360512c
commit ff06694adc
5 changed files with 22 additions and 22 deletions
Download patch file Download diff file Expand all files Collapse all files

10
fdroidserver/checkupdates.py
View file

@ -32,7 +32,7 @@ import logging
import common
import metadata
from common import VCSException
from common import VCSException, FDroidException
from metadata import MetaDataException
@ -44,7 +44,7 @@ def check_http(app):
try:
if 'Update Check Data' not in app:
raise Exception('Missing Update Check Data')
raise FDroidException('Missing Update Check Data')
urlcode, codeex, urlver, verex = app['Update Check Data'].split('|')
@ -57,7 +57,7 @@ def check_http(app):
m = re.search(codeex, page)
if not m:
raise Exception("No RE match for version code")
raise FDroidException("No RE match for version code")
vercode = m.group(1)
version = "??"
@ -70,12 +70,12 @@ def check_http(app):
m = re.search(verex, page)
if not m:
raise Exception("No RE match for version")
raise FDroidException("No RE match for version")
version = m.group(1)
return (version, vercode)
except Exception:
except FDroidException:
msg = "Could not complete http check for app {0} due to unknown error: {1}".format(app['id'], traceback.format_exc())
return (None, msg)