From e5fda5469373b6741deda1cb30af173d8352a5f2 Mon Sep 17 00:00:00 2001 From: Hans-Christoph Steiner Date: Mon, 24 Apr 2023 16:54:02 +0200 Subject: [PATCH] add test_check_metadata_AntiFeatures --- tests/metadata.TestCase | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/tests/metadata.TestCase b/tests/metadata.TestCase index 04da68ec..eed1baf4 100755 --- a/tests/metadata.TestCase +++ b/tests/metadata.TestCase @@ -180,6 +180,26 @@ class MetadataTest(unittest.TestCase): 'fake.app.id', ) + def test_check_metadata_AntiFeatures(self): + fdroidserver.metadata.warnings_action = 'error' + + app = fdroidserver.metadata.App() + self.assertIsNone(metadata.check_metadata(app)) + + app['AntiFeatures'] = [] + self.assertIsNone(metadata.check_metadata(app)) + + app['AntiFeatures'] = ['Ads', 'UpstreamNonFree'] + self.assertIsNone(metadata.check_metadata(app)) + + app['AntiFeatures'] = ['Ad'] + with self.assertRaises(fdroidserver.exception.MetaDataException): + metadata.check_metadata(app) + + app['AntiFeatures'] = ['Adss'] + with self.assertRaises(fdroidserver.exception.MetaDataException): + metadata.check_metadata(app) + def test_valid_funding_yml_regex(self): """Check the regex can find all the cases""" with (self.basedir / 'funding-usernames.yaml').open() as fp: