mirrors/fdroidserver
1
0
Fork 0
mirror of https://github.com/f-droid/fdroidserver.git synced 2025-09-14 06:52:39 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

metadata: slightly speed up post_metadata_parse

Browse source 
Iterating over all the fields and checking which are modified is slower
than just iterating over the modified ones.
This commit is contained in:
Daniel Martí 2016-01-11 13:25:03 +01:00
parent 7f6276889e
commit d98b4d1b83
1 changed files with 4 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

11
fdroidserver/metadata.py
View file

@ -842,17 +842,14 @@ esc_newlines = re.compile(r'\\( |\n)')
# This function uses __dict__ to be faster # This function uses __dict__ to be faster
def post_metadata_parse(app): def post_metadata_parse(app):
for k, v in app.__dict__.items(): for k in app._modified:
if k not in app._modified: v = app.__dict__[k]
continue
if type(v) in (float, int): if type(v) in (float, int):
app.__dict__[k] = str(v) app.__dict__[k] = str(v)
for build in app.builds: for build in app.builds:
for k, v in build.__dict__.items(): for k in build._modified:
v = build.__dict__[k]
if k not in build._modified:
continue
if type(v) in (float, int): if type(v) in (float, int):
build.__dict__[k] = str(v) build.__dict__[k] = str(v)
continue continue