mirrors/fdroidserver
1
0
Fork 0
mirror of https://github.com/f-droid/fdroidserver.git synced 2025-09-13 14:32:28 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

pre-commit: fix warnings and errors

Browse source 
Properly print warnings to stderr. Also, use : instead of 'echo' as a
fallback as the latter spits out garbage to stdout.

Examples without pep8 installed.

Before:

	 $ ./hooks/pre-commit
	./hooks/pre-commit: line 97: WARNING:: command not found
	ERROR: pep8 tests failed!

After:

	 $ ./hooks/pre-commit
	WARNING: pep8 is not installed, using dummy placeholder!
This commit is contained in:
Daniel Martí 2016-07-13 12:07:03 +01:00
parent 64d9eb3b13
commit d8a8c24584
1 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
hooks/pre-commit
View file

@ -59,12 +59,12 @@ fi
PEP8_IGNORE="E123,E501,W503" PEP8_IGNORE="E123,E501,W503"
err() { err() {
echo ERROR: "$@" echo >&2 ERROR: "$@"
exit 1 exit 1
} }
warn() { warn() {
echo WARNING: "$@" echo >&2 WARNING: "$@"
} }
cmd_exists() { cmd_exists() {
@ -81,7 +81,7 @@ find_command() {
fi fi
done done
warn "$1 is not installed, using dummy placeholder!" warn "$1 is not installed, using dummy placeholder!"
echo -n echo echo -n :
} }
PYFLAKES=$(find_command pyflakes) PYFLAKES=$(find_command pyflakes)