mirror of
				https://github.com/f-droid/fdroidserver.git
				synced 2025-11-04 06:30:27 +03:00 
			
		
		
		
	update: do not crash on screenshots without texts/graphics
`fdroid update` crashed for apps that only had screenshots but no graphics or localized texts because destdir was not being set in that case. This fixes that and adds a test case. closes #320 !286
This commit is contained in:
		
							parent
							
								
									e1d316a4bc
								
							
						
					
					
						commit
						d06f05e9c8
					
				
					 3 changed files with 2 additions and 1 deletions
				
			
		| 
						 | 
				
			
			@ -716,6 +716,7 @@ def insert_localized_app_metadata(apps):
 | 
			
		|||
                logging.debug(packageName + ' does not have app metadata, skipping l18n scan.')
 | 
			
		||||
                continue
 | 
			
		||||
            locale = segments[-1]
 | 
			
		||||
            destdir = os.path.join('repo', packageName, locale)
 | 
			
		||||
            for f in files:
 | 
			
		||||
                if f in ('description.txt', 'full_description.txt'):
 | 
			
		||||
                    _set_localized_text_entry(apps[packageName], locale, 'description',
 | 
			
		||||
| 
						 | 
				
			
			@ -742,7 +743,7 @@ def insert_localized_app_metadata(apps):
 | 
			
		|||
                base, extension = common.get_extension(f)
 | 
			
		||||
                if locale == 'images':
 | 
			
		||||
                    locale = segments[-2]
 | 
			
		||||
                destdir = os.path.join('repo', packageName, locale)
 | 
			
		||||
                    destdir = os.path.join('repo', packageName, locale)
 | 
			
		||||
                if base in GRAPHIC_NAMES and extension in ALLOWED_EXTENSIONS:
 | 
			
		||||
                    os.makedirs(destdir, mode=0o755, exist_ok=True)
 | 
			
		||||
                    logging.debug('copying ' + os.path.join(root, f) + ' ' + destdir)
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
										
											Binary file not shown.
										
									
								
							| 
		 After Width: | Height: | Size: 126 KiB  | 
										
											Binary file not shown.
										
									
								
							| 
		 After Width: | Height: | Size: 165 KiB  | 
		Loading…
	
	Add table
		Add a link
		
	
		Reference in a new issue