[checkupdates] move gradle var check to parser

3638acddc added a check if the version name string is actually a
unresolved gradle variable. This moves the check into the
common.parse_androidmanifests() as it is the only where the it could
happen. This also resolves the case where checkupdates returns
"Unknown".

Closes: #751
This commit is contained in:
Jochen Sprickerhof 2022-04-14 12:47:27 +02:00
parent ea567b0b5a
commit c19f46b706
2 changed files with 19 additions and 12 deletions

View file

@ -455,12 +455,6 @@ def checkupdates_app(app):
vercode = str(common.calculate_math_string(op))
logging.debug("Applied vercode operation: %s -> %s" % (oldvercode, vercode))
if version and any(version.startswith(s) for s in [
'${', # Gradle variable names
'@string/', # Strings we could not resolve
]):
version = "Unknown"
updating = False
if version is None:
raise FDroidException(_('no version information found'))