mirror of
				https://github.com/f-droid/fdroidserver.git
				synced 2025-11-04 06:30:27 +03:00 
			
		
		
		
	shell=True is too dangerous to allow; there are unfiltered user inputs
There are all sorts of unfiltered user inputs like tag and branch names in source repos. If those names are fed into popen calls that use shell=True, that opens up a wide range of exploits. All core operations should never use shell=True.
This commit is contained in:
		
							parent
							
								
									07cdf848d7
								
							
						
					
					
						commit
						b851d49d24
					
				
					 3 changed files with 17 additions and 11 deletions
				
			
		| 
						 | 
				
			
			@ -129,4 +129,8 @@ for f in $RB_FILES; do
 | 
			
		|||
	fi
 | 
			
		||||
done
 | 
			
		||||
 | 
			
		||||
if grep --line-number 'shell=True' fdroidserver/[a-ce-z]*.py; then
 | 
			
		||||
    err "shell=True is too dangerous, there are unfiltered user inputs!"
 | 
			
		||||
fi
 | 
			
		||||
 | 
			
		||||
exit 0
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
		Loading…
	
	Add table
		Add a link
		
	
		Reference in a new issue