mirrors/fdroidserver
1
0
Fork 0
mirror of https://github.com/f-droid/fdroidserver.git synced 2025-10-07 09:51:07 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

convert App to subclass of dict to support parsing/dumping libs

Browse source 
Python is heavily based on its core data types, and dict is one of the more
important ones.  Even classes are basically a wrapper around a dict. This
converts metadata.App to be a subclass of dict so it can behave like a dict
when being dumped and loaded.  This makes its drastically easier to use
different data formats for build metadata and for sending data to the
client.  This approach will ultimately mean we no longer have to maintain
custom parsing and dumping code.

This also means then that the YAML/JSON field names will not have spaces in
them, and they will match exactly what it used as the dict keys once the
data is parsed, as well as matching exactly the instance attribute names:

* CurrentVersion: 1.2.6
* app['CurrentVersion'] == '1.2.6'
* app.CurrentVersion == '1.2.6'

Inspired by:
https://goodcode.io/articles/python-dict-object/
This commit is contained in:
Hans-Christoph Steiner 2016-11-23 17:25:59 +01:00
parent 4625651192
commit b7fc7f2228
10 changed files with 165 additions and 229 deletions
Download patch file Download diff file Expand all files Collapse all files

38
tests/metadata/dump/org.adaway.yaml
View file

@ -1,17 +1,17 @@
AntiFeatures: []
Archive Policy: null
Author Email: null
Author Name: null
Auto Name: AdAway
Auto Update Mode: Version v%v
ArchivePolicy: null
AuthorEmail: null
AuthorName: null
AutoName: AdAway
AutoUpdateMode: Version v%v
Binaries: null
Bitcoin: null
Categories:
- System
- Security
Changelog: ''
Current Version: '3.0'
Current Version Code: '52'
CurrentVersion: '3.0'
CurrentVersionCode: '52'
Description: 'An ad blocker that uses the hosts file. The hosts file
contains a list of mappings between hostnames and IP addresses. When
@ -38,24 +38,24 @@ Description: 'An ad blocker that uses the hosts file. The hosts file
Disabled: null
Donate: http://sufficientlysecure.org/index.php/adaway
FlattrID: '369138'
Issue Tracker: https://github.com/dschuermann/ad-away/issues
IssueTracker: https://github.com/dschuermann/ad-away/issues
License: GPLv3
Litecoin: null
Maintainer Notes: ''
MaintainerNotes: ''
Name: null
No Source Since: ''
NoSourceSince: ''
Provides: org.sufficientlysecure.adaway
Repo: https://github.com/dschuermann/ad-away.git
Repo Type: git
Requires Root: true
Source Code: https://github.com/dschuermann/ad-away
RepoType: git
RequiresRoot: true
SourceCode: https://github.com/dschuermann/ad-away
Summary: Block advertisements
Update Check Data: null
Update Check Ignore: null
Update Check Mode: Tags
Update Check Name: null
Vercode Operation: null
Web Site: http://sufficientlysecure.org/index.php/adaway
UpdateCheckData: null
UpdateCheckIgnore: null
UpdateCheckMode: Tags
UpdateCheckName: null
VercodeOperation: null
WebSite: http://sufficientlysecure.org/index.php/adaway
added: null
builds:
- antcommands: []