mirrors/fdroidserver
1
0
Fork 0
mirror of https://github.com/f-droid/fdroidserver.git synced 2025-09-15 15:32:30 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

workaround crash in diffoscope when verifying APKs

Browse source 
On versions of diffoscope before 87, like the version included in Ubuntu
xenial LTS, it would crash saying:

ValueError: max_diff_block_lines (100) cannot be smaller than max_page_diff_block_lines (128)

https://bugs.debian.org/875451
This commit is contained in:
Hans-Christoph Steiner 2018-05-25 10:00:32 +02:00
parent 5afba57212
commit b0a5ec5c1a
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
fdroidserver/common.py
View file

@ -2788,7 +2788,7 @@ def compare_apks(apk1, apk2, tmp_dir, log_dir=None):
htmlfile = logfilename + '.diffoscope.html'
textfile = logfilename + '.diffoscope.txt'
if subprocess.call([config['diffoscope'],
'--max-report-size', '12345678', '--max-diff-block-lines', '100',
'--max-report-size', '12345678', '--max-diff-block-lines', '128',
'--html', htmlfile, '--text', textfile,
absapk1, absapk2]) != 0:
return("Failed to run diffoscope " + apk1)