From aea2589c673c06fc62605c43bcb2b28f3bc9dd91 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michael=20P=C3=B6hn?= Date: Sun, 19 Aug 2018 13:18:12 +0200 Subject: [PATCH] metadata: remove redundant build flags list creation picked out of fdroid/fdroidserver!559 --- fdroidserver/metadata.py | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/fdroidserver/metadata.py b/fdroidserver/metadata.py index 6a1869a7..7ea2832d 100644 --- a/fdroidserver/metadata.py +++ b/fdroidserver/metadata.py @@ -1096,6 +1096,11 @@ def parse_yaml_metadata(mf, app): def write_yaml(mf, app): + """Write metadata in yaml format. + + :param mf: active file discriptor for writing + :param app: app metadata to written to the yaml file + """ # import rumael.yaml and check version try: @@ -1176,12 +1181,10 @@ def write_yaml(mf, app): return cm def _builds_to_yaml(app): - fields = ['versionName', 'versionCode'] - fields.extend(build_flags_order) builds = ruamel.yaml.comments.CommentedSeq() for build in app.builds: b = ruamel.yaml.comments.CommentedMap() - for field in fields: + for field in build_flags: if hasattr(build, field) and getattr(build, field): value = getattr(build, field) if field == 'gradle' and value == ['off']: