mirrors/fdroidserver
1
0
Fork 0
mirror of https://github.com/f-droid/fdroidserver.git synced 2025-09-14 23:12:46 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

lint: complain about UCMs that haven't been used

Browse source 
Mainly for MRs from people who don't fill the automatic fields
This commit is contained in:
Daniel Martí 2015-08-05 10:52:53 -07:00
parent bad611ce5a
commit 9fc583289e
1 changed files with 10 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

10
fdroidserver/lint.py
View file

@ -138,6 +138,8 @@ def main():
allapps = metadata.read_metadata(xref=False) allapps = metadata.read_metadata(xref=False)
apps = common.read_app_args(args, allapps, False) apps = common.read_app_args(args, allapps, False)
filling_ucms = re.compile('^(Tags.*|RepoManifest.*)')
for appid, app in apps.iteritems(): for appid, app in apps.iteritems():
if app['Disabled']: if app['Disabled']:
continue continue
@ -171,6 +173,14 @@ def main():
if app['Web Site'].lower() == app['Source Code'].lower(): if app['Web Site'].lower() == app['Source Code'].lower():
warn("Website '%s' is just the app's source code link" % app['Web Site']) warn("Website '%s' is just the app's source code link" % app['Web Site'])
if filling_ucms.match(app['Update Check Mode']):
if all(app[f] == metadata.app_defaults[f] for f in [
'Auto Name',
'Current Version',
'Current Version Code',
]):
warn("UCM is set but it looks like checkupdates hasn't been run yet")
# Missing or incorrect categories # Missing or incorrect categories
if not app['Categories']: if not app['Categories']:
warn("Categories are not set") warn("Categories are not set")