From 9b59d5cf48a69908c2bc2efdfb50188f59f1abcf Mon Sep 17 00:00:00 2001
From: linsui <2873532-linsui@users.noreply.gitlab.com>
Date: Wed, 11 Dec 2024 23:13:58 +0800
Subject: [PATCH] update: extract archive policy calculation to common

---
 fdroidserver/common.py | 14 ++++++++++++++
 fdroidserver/update.py | 12 +++---------
 2 files changed, 17 insertions(+), 9 deletions(-)

diff --git a/fdroidserver/common.py b/fdroidserver/common.py
index f600d0d2..5f812206 100644
--- a/fdroidserver/common.py
+++ b/fdroidserver/common.py
@@ -4705,6 +4705,20 @@ def _install_ndk(ndk):
         )
 
 
+def calculate_archive_policy(app, default):
+    """Calculate the archive policy from the metadata and default config."""
+    if app.get('ArchivePolicy') is not None:
+        archive_policy = app['ArchivePolicy']
+    else:
+        archive_policy = default
+        if app.get('VercodeOperation'):
+            archive_policy *= len(app['VercodeOperation'])
+    builds = [build for build in app.Builds if not build.disable]
+    if app.Builds and archive_policy > len(builds):
+        archive_policy = len(builds)
+    return archive_policy
+
+
 FDROIDORG_MIRRORS = [
     {
         'isPrimary': True,
diff --git a/fdroidserver/update.py b/fdroidserver/update.py
index 7d443747..e038e166 100644
--- a/fdroidserver/update.py
+++ b/fdroidserver/update.py
@@ -2276,15 +2276,9 @@ def archive_old_apks(apps, apks, archapks, repodir, archivedir, defaultkeepversi
         return sorted_list
 
     for appid, app in apps.items():
-
-        if app.get('ArchivePolicy') is not None:
-            keepversions = app['ArchivePolicy']
-        else:
-            keepversions = defaultkeepversions
-            if app.get('VercodeOperation'):
-                keepversions *= len(app['VercodeOperation'])
-            if common.metadata_find_developer_signing_files(appid, app['CurrentVersionCode']):
-                keepversions *= 2
+        keepversions = common.calculate_archive_policy(app, defaultkeepversions)
+        if common.metadata_find_developer_signing_files(appid, app['CurrentVersionCode']):
+            keepversions *= 2
 
         logging.debug(_("Checking archiving for {appid} - apks:{integer}, keepversions:{keep}, archapks:{arch}")
                       .format(appid=appid, integer=len(apks), keep=keepversions, arch=len(archapks)))