run 'zipalign' using standard flags used by Gradle Android Plugin

Nice find by @equeim!  -p was added in build-tools-23.0.0

https://developer.android.com/studio/publish/app-signing#sign-manually

closes #288
This commit is contained in:
Hans-Christoph Steiner 2018-06-19 15:07:55 +02:00
parent deccd013c9
commit 8f2ee4bd1d
2 changed files with 16 additions and 11 deletions

View file

@ -33,7 +33,7 @@ import zipfile
from . import _
from . import common
from . import metadata
from .common import FDroidPopen, SdkToolsPopen
from .common import FDroidPopen
from .exception import BuildException, FDroidException
config = None
@ -350,10 +350,7 @@ def main():
raise BuildException(_("Failed to sign application"), p.output)
# Zipalign it...
p = SdkToolsPopen(['zipalign', '-v', '4', apkfile,
os.path.join(output_dir, apkfilename)])
if p.returncode != 0:
raise BuildException(_("Failed to align application"))
common._zipalign(apkfile, os.path.join(output_dir, apkfilename))
os.remove(apkfile)
publish_source_tarball(apkfilename, unsigned_dir, output_dir)