mirror of
				https://github.com/f-droid/fdroidserver.git
				synced 2025-11-03 22:20:28 +03:00 
			
		
		
		
	Don't copy per version anti features to all versions
make_v0() modified the apps data structure to copy an anti feature for a specific version to all versions resulting in index-v1 and -v2 to contain wrong anti feature annotations. This patch fixes this and adds a test that the data structure is no longer modified. The bug shadowed bugs in the AF implementation of -v1 and -v2 resulting in not coping the version specific data. This is corrected as well. This is also tested now. For -v2 the AF dict is now sorted to make the result reproducible. Finally The NoSourceSince AF was added as a per version and overall AF in -v1 and is now only applied as an overall AF and the test is updated accordingly.
This commit is contained in:
		
							parent
							
								
									484f289919
								
							
						
					
					
						commit
						889b8cb372
					
				
					 10 changed files with 63 additions and 67 deletions
				
			
		| 
						 | 
				
			
			@ -170,7 +170,8 @@
 | 
			
		|||
    },
 | 
			
		||||
    {
 | 
			
		||||
      "antiFeatures": [
 | 
			
		||||
        "NoSourceSince"
 | 
			
		||||
        "NoSourceSince",
 | 
			
		||||
        "NonFreeNet"
 | 
			
		||||
      ],
 | 
			
		||||
      "categories": [
 | 
			
		||||
        "Time"
 | 
			
		||||
| 
						 | 
				
			
			@ -230,9 +231,6 @@
 | 
			
		|||
    "com.politedroid": [
 | 
			
		||||
      {
 | 
			
		||||
        "added": 1498176000000,
 | 
			
		||||
        "antiFeatures": [
 | 
			
		||||
          "NoSourceSince"
 | 
			
		||||
        ],
 | 
			
		||||
        "apkName": "com.politedroid_6.apk",
 | 
			
		||||
        "hash": "70c2f776a2bac38a58a7d521f96ee0414c6f0fb1de973c3ca8b10862a009247d",
 | 
			
		||||
        "hashType": "sha256",
 | 
			
		||||
| 
						 | 
				
			
			@ -257,9 +255,6 @@
 | 
			
		|||
      },
 | 
			
		||||
      {
 | 
			
		||||
        "added": 1498176000000,
 | 
			
		||||
        "antiFeatures": [
 | 
			
		||||
          "NoSourceSince"
 | 
			
		||||
        ],
 | 
			
		||||
        "apkName": "com.politedroid_5.apk",
 | 
			
		||||
        "hash": "5bdbfa071cca4b8d05ced41d6b28763595d6e8096cca5bbf0f9253c9a2622e5d",
 | 
			
		||||
        "hashType": "sha256",
 | 
			
		||||
| 
						 | 
				
			
			@ -284,9 +279,6 @@
 | 
			
		|||
      },
 | 
			
		||||
      {
 | 
			
		||||
        "added": 1498176000000,
 | 
			
		||||
        "antiFeatures": [
 | 
			
		||||
          "NoSourceSince"
 | 
			
		||||
        ],
 | 
			
		||||
        "apkName": "com.politedroid_4.apk",
 | 
			
		||||
        "hash": "c809bdff83715fbf919f3840ee09869b038e209378b906e135ee40d3f0e1f075",
 | 
			
		||||
        "hashType": "sha256",
 | 
			
		||||
| 
						 | 
				
			
			@ -324,7 +316,6 @@
 | 
			
		|||
        "added": 1498176000000,
 | 
			
		||||
        "antiFeatures": [
 | 
			
		||||
          "KnownVuln",
 | 
			
		||||
          "NoSourceSince",
 | 
			
		||||
          "NonFreeAssets",
 | 
			
		||||
          "UpstreamNonFree"
 | 
			
		||||
        ],
 | 
			
		||||
| 
						 | 
				
			
			@ -698,4 +689,4 @@
 | 
			
		|||
      }
 | 
			
		||||
    ]
 | 
			
		||||
  }
 | 
			
		||||
}
 | 
			
		||||
}
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
		Loading…
	
	Add table
		Add a link
		
	
		Reference in a new issue