lint: warn about CVCs that don't make sense

This commit is contained in:
Daniel Martí 2015-08-14 14:16:43 -07:00
parent 6cc91e2ded
commit 712c3aaae9

View file

@ -147,8 +147,15 @@ def main():
curid = appid curid = appid
count['app_total'] += 1 count['app_total'] += 1
# enabled_builds = 0
lowest_vercode = -1
curbuild = None curbuild = None
for build in app['builds']: for build in app['builds']:
if not build['disable']:
# enabled_builds += 1
vercode = int(build['vercode'])
if lowest_vercode == -1 or vercode < lowest_vercode:
lowest_vercode = vercode
if not curbuild or int(build['vercode']) > int(curbuild['vercode']): if not curbuild or int(build['vercode']) > int(curbuild['vercode']):
curbuild = build curbuild = build
@ -181,6 +188,10 @@ def main():
]): ]):
warn("UCM is set but it looks like checkupdates hasn't been run yet") warn("UCM is set but it looks like checkupdates hasn't been run yet")
cvc = int(app['Current Version Code'])
if cvc > 0 and cvc < lowest_vercode:
warn("Current Version Code is lower than any enabled build")
# Missing or incorrect categories # Missing or incorrect categories
if not app['Categories']: if not app['Categories']:
warn("Categories are not set") warn("Categories are not set")