From c1500e4ca1d98d2139d04370f53f42248202093a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michael=20P=C3=B6hn?= Date: Tue, 9 Jan 2024 09:21:19 +0100 Subject: [PATCH 1/8] =?UTF-8?q?=F0=9F=97=A8=20iOS=20text=20metadata=20supp?= =?UTF-8?q?ort?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This change adds basic i18n support for parsing iOS fastlane metadata. Currently supported: * name * subtitle (summary) * description --- fdroidserver/update.py | 32 ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) diff --git a/fdroidserver/update.py b/fdroidserver/update.py index eaf1bb8b..1d204090 100644 --- a/fdroidserver/update.py +++ b/fdroidserver/update.py @@ -34,6 +34,7 @@ import json import time import yaml import copy +import pathlib import defusedxml.ElementTree as ElementTree from datetime import datetime, timezone from argparse import ArgumentParser @@ -1208,6 +1209,36 @@ def insert_localized_app_metadata(apps): logging.warning(_('Unsupported graphics file found: {path}').format(path=f)) +LANG_CODE = re.compile(r'^[a-z]{2}([-_][A-Z][a-zA-Z]{1,3})?$') + + +FASTLANE_IOS_MAP = { + "name.txt": 'name', + "subtitle.txt": 'summary', + "description.txt": 'description', +} + + +def insert_localized_ios_app_metadata(apps_with_packages): + + for package_name, app in apps_with_packages.items(): + if not any(pathlib.Path('repo').glob(f'{package_name}*.ipa')): + # couldn't find any IPA files for this package_name + # so we don't have to look for fastlane data + continue + + fastlane_dir = pathlib.Path('build', package_name, 'fastlane') + + for lang_dir in (fastlane_dir / 'metadata').iterdir(): + lang_code = lang_dir.name + m = LANG_CODE.match(lang_code) + if m: + for metadata_file in (lang_dir).iterdir(): + key = FASTLANE_IOS_MAP.get(metadata_file.name) + if key: + _set_localized_text_entry(app, lang_code, key, metadata_file) + + def scan_repo_files(apkcache, repodir, knownapks, use_date_from_file=False): """Scan a repo for all files with an extension except APK/OBB/IPA. @@ -2240,6 +2271,7 @@ def prepare_apps(apps, apks, repodir): translate_per_build_anti_features(apps_with_packages, apks) if repodir == 'repo': insert_localized_app_metadata(apps_with_packages) + insert_localized_ios_app_metadata(apps_with_packages) insert_missing_app_names_from_apks(apps_with_packages, apks) return apps_with_packages From c166a8a2b7deea20e85137c8065d166a5041add2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michael=20P=C3=B6hn?= Date: Fri, 2 Feb 2024 14:08:27 +0100 Subject: [PATCH 2/8] =?UTF-8?q?=F0=9F=AA=84=20split=20screenshot=20ingesti?= =?UTF-8?q?on=20into=20separate=20function?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- fdroidserver/update.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/fdroidserver/update.py b/fdroidserver/update.py index 1d204090..ab94f62e 100644 --- a/fdroidserver/update.py +++ b/fdroidserver/update.py @@ -1149,6 +1149,8 @@ def insert_localized_app_metadata(apps): os.makedirs(screenshotdestdir, mode=0o755, exist_ok=True) _strip_and_copy_image(f, screenshotdestdir) + +def ingest_screenshots_from_repo_dir(apps): repodirs = sorted(glob.glob(os.path.join('repo', '[A-Za-z]*', '[a-z][a-z]*'))) for d in repodirs: if not os.path.isdir(d): @@ -2272,6 +2274,7 @@ def prepare_apps(apps, apks, repodir): if repodir == 'repo': insert_localized_app_metadata(apps_with_packages) insert_localized_ios_app_metadata(apps_with_packages) + ingest_screenshots_from_repo_dir(apps_with_packages) insert_missing_app_names_from_apks(apps_with_packages, apks) return apps_with_packages From 293caf5ff93f9480346e4c93c5e74df324e718af Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michael=20P=C3=B6hn?= Date: Mon, 12 Feb 2024 00:55:16 +0100 Subject: [PATCH 3/8] =?UTF-8?q?=F0=9F=AA=AA=20iOS=20fastlane=20screenshot?= =?UTF-8?q?=20support?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- fdroidserver/update.py | 53 ++++++++++++++++++++++++++++++++++++++++++ tests/update.TestCase | 2 ++ 2 files changed, 55 insertions(+) diff --git a/fdroidserver/update.py b/fdroidserver/update.py index ab94f62e..8839c531 100644 --- a/fdroidserver/update.py +++ b/fdroidserver/update.py @@ -1137,6 +1137,9 @@ def insert_localized_app_metadata(apps): if base not in apps[packageName] or not isinstance(apps[packageName][base], collections.OrderedDict): apps[packageName][base] = collections.OrderedDict() apps[packageName][base][locale] = common.file_entry(dst) + + # copy screenshots from local source code checkout into wellknown + # location in repo directory for d in dirs: if d in SCREENSHOT_DIRS: if locale == 'images': @@ -1221,8 +1224,33 @@ FASTLANE_IOS_MAP = { } +def parse_ios_screenshot_name(path): + """ + Infer type info from screenshot file name. + + Device type/name is part of the file name of iOS fastlane screenshots. + Here are some example: + * 'iPhone 8+ @ iOS 16-1.png' + * 'iPad Pro 12.9" 2gen @ iOS 16-1.png' + * '1_ipadPro129_1.1.png' + * '1_iphone6Plus_1.1.png' + """ + s = path.stem.split('@') + if len(s) >= 2: + if "iphone" in s[0].lower(): + return ("phoneScreenshots", '@'.join(s[1:])) + elif "ipad" in s[0].lower(): + return ("tenInchScreenshots", "@".join(s[1:])) + else: + return ('phoneScreenshots', s[0]) + + def insert_localized_ios_app_metadata(apps_with_packages): + if not any(pathlib.Path('repo').glob('*.ipa')): + # no IPA files present in repo, nothing to do here, exiting early + return + for package_name, app in apps_with_packages.items(): if not any(pathlib.Path('repo').glob(f'{package_name}*.ipa')): # couldn't find any IPA files for this package_name @@ -1240,6 +1268,31 @@ def insert_localized_ios_app_metadata(apps_with_packages): if key: _set_localized_text_entry(app, lang_code, key, metadata_file) + # discover available screenshots and put findings in a dict + screenshots = {} + for lang_sdir in (fastlane_dir / 'screenshots').iterdir(): + lang_code = lang_sdir.name + m = LANG_CODE.match(lang_code) + if m: + screenshots[lang_code] = {} + for screenshot in (lang_sdir).iterdir(): + if screenshot.suffix[1:] in ALLOWED_EXTENSIONS: + # asdf #TODO + device_name, screenshot_name = parse_ios_screenshot_name(screenshot) + + if not screenshots[lang_code].get(device_name): + screenshots[lang_code][device_name] = {} + screenshots[lang_code][device_name][screenshot_name] = screenshot + + # copy screenshots to repo dir + for lang_code in screenshots.keys(): + for device in screenshots[lang_code].keys(): + dest_dir = pathlib.Path('repo') / package_name / lang_code / device + dest_dir.mkdir(mode=0o755, parents=True, exist_ok=True) + for name, path in screenshots[lang_code][device].items(): + dest = dest_dir / (name.replace(" ", "_").replace("\t", "_") + path.suffix) + _strip_and_copy_image(str(path), str(dest)) + def scan_repo_files(apkcache, repodir, knownapks, use_date_from_file=False): """Scan a repo for all files with an extension except APK/OBB/IPA. diff --git a/tests/update.TestCase b/tests/update.TestCase index bebab3f0..37e4be9b 100755 --- a/tests/update.TestCase +++ b/tests/update.TestCase @@ -165,6 +165,7 @@ class UpdateTest(unittest.TestCase): apps['eu.siacs.conversations']['Builds'] = [build_conversations] fdroidserver.update.insert_localized_app_metadata(apps) + fdroidserver.update.ingest_screenshots_from_repo_dir(apps) appdir = os.path.join('repo', 'info.guardianproject.urzip', 'en-US') self.assertTrue( @@ -278,6 +279,7 @@ class UpdateTest(unittest.TestCase): knownapks = fdroidserver.common.KnownApks() apks, cachechanged = fdroidserver.update.process_apks({}, 'repo', knownapks, False) fdroidserver.update.insert_localized_app_metadata(apps) + fdroidserver.update.ingest_screenshots_from_repo_dir(apps) fdroidserver.update.apply_info_from_latest_apk(apps, apks) app = apps['info.guardianproject.urzip'] self.assertIsNone(app.Name) From 53185ea2e76848707fd902539a2dd21dfa98e534 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michael=20P=C3=B6hn?= Date: Thu, 14 Mar 2024 13:51:11 +0100 Subject: [PATCH 4/8] =?UTF-8?q?=F0=9F=AB=8F=20appeace=20linter?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- fdroidserver/update.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fdroidserver/update.py b/fdroidserver/update.py index 8839c531..421b6aff 100644 --- a/fdroidserver/update.py +++ b/fdroidserver/update.py @@ -1285,11 +1285,11 @@ def insert_localized_ios_app_metadata(apps_with_packages): screenshots[lang_code][device_name][screenshot_name] = screenshot # copy screenshots to repo dir - for lang_code in screenshots.keys(): - for device in screenshots[lang_code].keys(): + for lang_code, translated_screenshots in screenshots.items(): + for device, translated_device_screenthos in translated_screenshots.items(): dest_dir = pathlib.Path('repo') / package_name / lang_code / device dest_dir.mkdir(mode=0o755, parents=True, exist_ok=True) - for name, path in screenshots[lang_code][device].items(): + for name, path in translated_device_screenshots.items(): dest = dest_dir / (name.replace(" ", "_").replace("\t", "_") + path.suffix) _strip_and_copy_image(str(path), str(dest)) From 806a07b7190c612b5191ddacb395d971318494fc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michael=20P=C3=B6hn?= Date: Thu, 14 Mar 2024 15:07:44 +0100 Subject: [PATCH 5/8] =?UTF-8?q?=F0=9F=AB=8F=20better=20variable=20name?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- fdroidserver/update.py | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/fdroidserver/update.py b/fdroidserver/update.py index 421b6aff..0f005f37 100644 --- a/fdroidserver/update.py +++ b/fdroidserver/update.py @@ -1260,34 +1260,34 @@ def insert_localized_ios_app_metadata(apps_with_packages): fastlane_dir = pathlib.Path('build', package_name, 'fastlane') for lang_dir in (fastlane_dir / 'metadata').iterdir(): - lang_code = lang_dir.name - m = LANG_CODE.match(lang_code) + locale = lang_dir.name + m = LANG_CODE.match(locale) if m: for metadata_file in (lang_dir).iterdir(): key = FASTLANE_IOS_MAP.get(metadata_file.name) if key: - _set_localized_text_entry(app, lang_code, key, metadata_file) + _set_localized_text_entry(app, locale, key, metadata_file) # discover available screenshots and put findings in a dict screenshots = {} for lang_sdir in (fastlane_dir / 'screenshots').iterdir(): - lang_code = lang_sdir.name - m = LANG_CODE.match(lang_code) + locale = lang_sdir.name + m = LANG_CODE.match(locale) if m: - screenshots[lang_code] = {} + screenshots[locale] = {} for screenshot in (lang_sdir).iterdir(): if screenshot.suffix[1:] in ALLOWED_EXTENSIONS: # asdf #TODO device_name, screenshot_name = parse_ios_screenshot_name(screenshot) - if not screenshots[lang_code].get(device_name): - screenshots[lang_code][device_name] = {} - screenshots[lang_code][device_name][screenshot_name] = screenshot + if not screenshots[locale].get(device_name): + screenshots[locale][device_name] = {} + screenshots[locale][device_name][screenshot_name] = screenshot # copy screenshots to repo dir - for lang_code, translated_screenshots in screenshots.items(): + for locale, translated_screenshots in screenshots.items(): for device, translated_device_screenthos in translated_screenshots.items(): - dest_dir = pathlib.Path('repo') / package_name / lang_code / device + dest_dir = pathlib.Path('repo') / package_name / locale / device dest_dir.mkdir(mode=0o755, parents=True, exist_ok=True) for name, path in translated_device_screenshots.items(): dest = dest_dir / (name.replace(" ", "_").replace("\t", "_") + path.suffix) From bbf17ee59c4490ac11af3d3c70ea599023f4dab8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michael=20P=C3=B6hn?= Date: Mon, 18 Mar 2024 14:01:36 +0100 Subject: [PATCH 6/8] =?UTF-8?q?=F0=9F=A7=86=20improve=20and=20test=20parse?= =?UTF-8?q?=5Fios=5Fscreenshot=5Fname?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- fdroidserver/update.py | 49 ++++++++++++++++++++++++++++-------------- tests/update.TestCase | 29 +++++++++++++++++++++++++ 2 files changed, 62 insertions(+), 16 deletions(-) diff --git a/fdroidserver/update.py b/fdroidserver/update.py index 0f005f37..d9a812cb 100644 --- a/fdroidserver/update.py +++ b/fdroidserver/update.py @@ -1226,23 +1226,34 @@ FASTLANE_IOS_MAP = { def parse_ios_screenshot_name(path): """ - Infer type info from screenshot file name. + Infer type and categorization info from screenshot file name. - Device type/name is part of the file name of iOS fastlane screenshots. - Here are some example: - * 'iPhone 8+ @ iOS 16-1.png' - * 'iPad Pro 12.9" 2gen @ iOS 16-1.png' - * '1_ipadPro129_1.1.png' - * '1_iphone6Plus_1.1.png' + This is not really an exact algorithm, it's based on filenames observed in + the wild. """ s = path.stem.split('@') if len(s) >= 2: if "iphone" in s[0].lower(): - return ("phoneScreenshots", '@'.join(s[1:])) + return ("phoneScreenshots", s[0].strip(), ('@'.join(s[1:])).split('-')[0].strip()) elif "ipad" in s[0].lower(): - return ("tenInchScreenshots", "@".join(s[1:])) + return ("tenInchScreenshots", s[0].strip(), ('@'.join(s[1:])).split('-')[0].strip()) else: - return ('phoneScreenshots', s[0]) + fragments = path.stem.lower().split("_") + device = "unknown" + os = "unknown" + screenshot_type = "phoneScreenshots" + for f in fragments: + if "iphone" in f: + device = f + continue + if "ipad" in f: + screenshot_type = "tenInchScreenshots" + device = f + if "ios" in f: + os = f + return (screenshot_type, device, os) + + return ("phoneScreenshots", 'unknown', 'unknown') def insert_localized_ios_app_metadata(apps_with_packages): @@ -1275,18 +1286,24 @@ def insert_localized_ios_app_metadata(apps_with_packages): m = LANG_CODE.match(locale) if m: screenshots[locale] = {} + fcfs_idevice = None + fcfs_ios = None for screenshot in (lang_sdir).iterdir(): if screenshot.suffix[1:] in ALLOWED_EXTENSIONS: - # asdf #TODO - device_name, screenshot_name = parse_ios_screenshot_name(screenshot) + screenshot_type, idevice_name, ios_name = parse_ios_screenshot_name(screenshot) - if not screenshots[locale].get(device_name): - screenshots[locale][device_name] = {} - screenshots[locale][device_name][screenshot_name] = screenshot + if not fcfs_idevice: + fcfs_idevice = idevice_name + fcfs_ios = ios_name + + if fcfs_idevice == idevice_name and fcfs_ios == ios_name: + if not screenshots[locale].get(screenshot_type): + screenshots[locale][screenshot_type] = {} + screenshots[locale][screenshot_type][screenshot] = screenshot # copy screenshots to repo dir for locale, translated_screenshots in screenshots.items(): - for device, translated_device_screenthos in translated_screenshots.items(): + for device, translated_device_screenshots in translated_screenshots.items(): dest_dir = pathlib.Path('repo') / package_name / locale / device dest_dir.mkdir(mode=0o755, parents=True, exist_ok=True) for name, path in translated_device_screenshots.items(): diff --git a/tests/update.TestCase b/tests/update.TestCase index 37e4be9b..277a2270 100755 --- a/tests/update.TestCase +++ b/tests/update.TestCase @@ -2042,6 +2042,35 @@ class TestScanRepoForIpas(unittest.TestCase): ) +class TestParseIosScreenShotName(unittest.TestCase): + def setUp(self): + self.maxDiff = None + + def test_parse_ios_screenshot_name_atforamt_iphone8(self): + self.assertEqual( + fdroidserver.update.parse_ios_screenshot_name(Path("iPhone 8+ @ iOS 16-1.png")), + ("phoneScreenshots", "iPhone 8+", "iOS 16",), + ) + + def test_parse_ios_screenshot_name_atforamt_ipad13(self): + self.assertEqual( + fdroidserver.update.parse_ios_screenshot_name(Path("iPad Pro 12.9\" 2gen @ iOS 16-1.png")), + ("tenInchScreenshots", "iPad Pro 12.9\" 2gen", "iOS 16",), + ) + + def test_parse_ios_screenshot_name_underscoreforamt_ipad(self): + self.assertEqual( + fdroidserver.update.parse_ios_screenshot_name(Path("1_ipadPro129_1.1.png")), + ("tenInchScreenshots", "ipadpro129", "unknown",), + ) + + def test_parse_ios_screenshot_name_underscoreforamt_iphone(self): + self.assertEqual( + fdroidserver.update.parse_ios_screenshot_name(Path("1_iphone6Plus_1.1.png")), + ("phoneScreenshots", "iphone6plus", "unknown",), + ) + + if __name__ == "__main__": os.chdir(os.path.dirname(__file__)) From 6152abee08b82f203cc95d0db0a39736e3dc491d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michael=20P=C3=B6hn?= Date: Tue, 19 Mar 2024 23:30:45 +0100 Subject: [PATCH 7/8] =?UTF-8?q?=F0=9F=AA=80=20tests=20for=20insert=5Flocal?= =?UTF-8?q?ized=5Fios=5Fapp=5Fmetadata?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Split some functions from insert_localized_ios_app_metadata into sub-functions and implemented separate tests for each. --- fdroidserver/update.py | 100 +++++++++++++++++++------------ tests/update.TestCase | 133 +++++++++++++++++++++++++++++++++++++++++ 2 files changed, 195 insertions(+), 38 deletions(-) diff --git a/fdroidserver/update.py b/fdroidserver/update.py index d9a812cb..cc97c094 100644 --- a/fdroidserver/update.py +++ b/fdroidserver/update.py @@ -1256,6 +1256,56 @@ def parse_ios_screenshot_name(path): return ("phoneScreenshots", 'unknown', 'unknown') +def discover_ios_screenshots(fastlane_dir): + """Traverse git checkouts in build dir, search for fastlane-screenshots and put findings into a dict.""" + fastlane_screenshot_dir = fastlane_dir / 'screenshots' + screenshots = {} + if fastlane_screenshot_dir.is_dir(): + for lang_sdir in fastlane_screenshot_dir.iterdir(): + locale = lang_sdir.name + m = LANG_CODE.match(locale) + if m: + screenshots[locale] = {} + fifo_idevice = {} + fifo_ios = {} + for screenshot in lang_sdir.iterdir(): + if screenshot.suffix[1:] in ALLOWED_EXTENSIONS: + screenshot_type, idevice_name, ios_name = parse_ios_screenshot_name(screenshot) + + # since there is no easy mapping here, we're just + # resorting to fifo here, so ieg. if there's 2 + # screenshots categorized for more than one + # iPhone/iOS combinations we just remember the + # first combination, use them as screenshots in + # F-Droid and ignore all other screenshots, for + # this screenshot type + if not fifo_idevice.get(screenshot_type): + fifo_idevice[screenshot_type] = idevice_name + fifo_ios[screenshot_type] = ios_name + + if fifo_idevice[screenshot_type] == idevice_name and fifo_ios[screenshot_type] == ios_name: + if screenshot_type not in screenshots[locale]: + screenshots[locale][screenshot_type] = [] + screenshots[locale][screenshot_type].append(screenshot) + + # sort all found screenshots alphanumerically + for locale, translated_screenshots in screenshots.items(): + for device in translated_screenshots.keys(): + translated_screenshots[device].sort() + + return screenshots + + +def copy_ios_screenshots_to_repo(screenshots, package_name): + for locale, translated_screenshots in screenshots.items(): + for device, translated_device_screenshots in translated_screenshots.items(): + dest_dir = pathlib.Path('repo') / package_name / locale / device + dest_dir.mkdir(mode=0o755, parents=True, exist_ok=True) + for path in translated_device_screenshots: + dest = dest_dir / (path.name.replace(" ", "_").replace("\t", "_")) + fdroidserver.update._strip_and_copy_image(str(path), str(dest)) + + def insert_localized_ios_app_metadata(apps_with_packages): if not any(pathlib.Path('repo').glob('*.ipa')): @@ -1269,46 +1319,20 @@ def insert_localized_ios_app_metadata(apps_with_packages): continue fastlane_dir = pathlib.Path('build', package_name, 'fastlane') + fastlane_meta_dir = (fastlane_dir / "metadata") - for lang_dir in (fastlane_dir / 'metadata').iterdir(): - locale = lang_dir.name - m = LANG_CODE.match(locale) - if m: - for metadata_file in (lang_dir).iterdir(): - key = FASTLANE_IOS_MAP.get(metadata_file.name) - if key: - _set_localized_text_entry(app, locale, key, metadata_file) + if fastlane_meta_dir.is_dir(): + for lang_dir in fastlane_meta_dir.iterdir(): + locale = lang_dir.name + m = LANG_CODE.match(locale) + if m: + for metadata_file in (lang_dir).iterdir(): + key = FASTLANE_IOS_MAP.get(metadata_file.name) + if key: + fdroidserver.update._set_localized_text_entry(app, locale, key, metadata_file) - # discover available screenshots and put findings in a dict - screenshots = {} - for lang_sdir in (fastlane_dir / 'screenshots').iterdir(): - locale = lang_sdir.name - m = LANG_CODE.match(locale) - if m: - screenshots[locale] = {} - fcfs_idevice = None - fcfs_ios = None - for screenshot in (lang_sdir).iterdir(): - if screenshot.suffix[1:] in ALLOWED_EXTENSIONS: - screenshot_type, idevice_name, ios_name = parse_ios_screenshot_name(screenshot) - - if not fcfs_idevice: - fcfs_idevice = idevice_name - fcfs_ios = ios_name - - if fcfs_idevice == idevice_name and fcfs_ios == ios_name: - if not screenshots[locale].get(screenshot_type): - screenshots[locale][screenshot_type] = {} - screenshots[locale][screenshot_type][screenshot] = screenshot - - # copy screenshots to repo dir - for locale, translated_screenshots in screenshots.items(): - for device, translated_device_screenshots in translated_screenshots.items(): - dest_dir = pathlib.Path('repo') / package_name / locale / device - dest_dir.mkdir(mode=0o755, parents=True, exist_ok=True) - for name, path in translated_device_screenshots.items(): - dest = dest_dir / (name.replace(" ", "_").replace("\t", "_") + path.suffix) - _strip_and_copy_image(str(path), str(dest)) + screenshots = fdroidserver.update.discover_ios_screenshots(fastlane_dir) + fdroidserver.update.copy_ios_screenshots_to_repo(screenshots, package_name) def scan_repo_files(apkcache, repodir, knownapks, use_date_from_file=False): diff --git a/tests/update.TestCase b/tests/update.TestCase index 277a2270..81036cd6 100755 --- a/tests/update.TestCase +++ b/tests/update.TestCase @@ -2071,6 +2071,136 @@ class TestParseIosScreenShotName(unittest.TestCase): ) +class TestInsertLocalizedIosAppMetadata(unittest.TestCase): + + def test_insert_localized_ios_app_metadata(self): + self.maxDiff = None + + self.apps_with_packages = { + "org.fake": {} + } + + def _mock_discover(fastlane_dir): + self.assertEqual( + fastlane_dir, + Path('build/org.fake/fastlane'), + ) + return {"fake screenshots": "fake"} + + def _mock_copy(screenshots, package_name): + self.assertEqual(screenshots, {"fake screenshots": "fake"}) + self.assertEqual(package_name, "org.fake") + + with mock.patch('fdroidserver.update.discover_ios_screenshots', _mock_discover): + self.set_localized_mock = mock.Mock() + with mock.patch('fdroidserver.update.copy_ios_screenshots_to_repo', _mock_copy): + with mock.patch("fdroidserver.update._set_localized_text_entry", self.set_localized_mock): + return fdroidserver.update.insert_localized_ios_app_metadata( + self.apps_with_packages + ) + + self.assertListEqual( + self.set_localized_mock.call_args_list, + [ + mock.call({}, 'en-US', 'name', Path('build/org.fake/fastlane/metadata/en-US/name.txt')), + mock.call({}, 'en-US', 'summary', Path('build/org.fake/fastlane/metadata/en-US/subtitle.txt')), + mock.call({}, 'en-US', 'description', Path('build/org.fake/fastlane/metadata/en-US/description.txt')), + mock.call({}, 'de-DE', 'name', Path('build/org.fake/fastlane/metadata/de-DE/name.txt')), + mock.call({}, 'de-DE', 'summary', Path('build/org.fake/fastlane/metadata/de-DE/subtitle.txt')), + mock.call({}, 'de-DE', 'description', Path('build/org.fake/fastlane/metadata/de-DE/description.txt')), + ], + ) + + +class TestDiscoverIosScreenshots(unittest.TestCase): + def test_discover_ios_screenshots(self): + self.maxDiff = None + + with tempfile.TemporaryDirectory() as fastlane_dir: + fastlane_dir = Path(fastlane_dir) + (fastlane_dir / "screenshots/en-US").mkdir(parents=True) + with open(fastlane_dir / "screenshots/en-US/iPhone 8+ @ iOS 16-1.png", 'w') as f: + f.write("1") + with open(fastlane_dir / "screenshots/en-US/iPad Pro 12.9\" 2gen @ iOS 16-1.png", "w") as f: + f.write("2") + with open(fastlane_dir / "screenshots/en-US/iPad Pro 12.9\" 2gen @ iOS 16-2.png", "w") as f: + f.write("3") + (fastlane_dir / "screenshots/de-DE").mkdir(parents=True) + with open(fastlane_dir / "screenshots/de-DE/1_ipadPro129_1.1.png", "w") as f: + f.write("4") + + screenshots = fdroidserver.update.discover_ios_screenshots(fastlane_dir) + + self.assertDictEqual( + screenshots, + { + "en-US": { + "phoneScreenshots": [ + fastlane_dir / "screenshots/en-US/iPhone 8+ @ iOS 16-1.png", + ], + "tenInchScreenshots": [ + fastlane_dir / "screenshots/en-US/iPad Pro 12.9\" 2gen @ iOS 16-1.png", + fastlane_dir / "screenshots/en-US/iPad Pro 12.9\" 2gen @ iOS 16-2.png", + ], + }, + "de-DE": { + "tenInchScreenshots": [ + fastlane_dir / "screenshots/de-DE/1_ipadPro129_1.1.png", + ], + }, + }, + ) + + +class TestCopyIosScreenshotsToRepo(unittest.TestCase): + def test_copy_ios_screenshots_to_repo(self): + self.maxDiff = None + + screenshot_dir_en = Path("build/org.fake/fastlane/screenshots/en-US") + s1 = screenshot_dir_en / "iPhone 8+ @ iOS 16-1.png" + s2 = screenshot_dir_en / "iPad Pro 12.9\" 2gen @ iOS 16-1.png" + s3 = screenshot_dir_en / "iPad Pro 12.9\" 2gen @ iOS 16-2.png" + screenshot_dir_de = Path("build/org.fake/fastlane/screenshots/de-DE") + s4 = screenshot_dir_de / "1_ipadPro129_1.1.png" + + cmock = mock.Mock() + with mock.patch("fdroidserver.update._strip_and_copy_image", cmock): + fdroidserver.update.copy_ios_screenshots_to_repo( + { + "en-US": { + "phoneScreenshots": [s1], + "tenInchScreenshots": [s2, s3], + }, + "de-DE": { + "tenInchScreenshots": [s4], + }, + }, + "org.fake", + ) + + self.assertListEqual( + cmock.call_args_list, + [ + mock.call( + 'build/org.fake/fastlane/screenshots/en-US/iPhone 8+ @ iOS 16-1.png', + 'repo/org.fake/en-US/phoneScreenshots/iPhone_8+_@_iOS_16-1.png', + ), + mock.call( + 'build/org.fake/fastlane/screenshots/en-US/iPad Pro 12.9" 2gen @ iOS 16-1.png', + 'repo/org.fake/en-US/tenInchScreenshots/iPad_Pro_12.9"_2gen_@_iOS_16-1.png', + ), + mock.call( + 'build/org.fake/fastlane/screenshots/en-US/iPad Pro 12.9" 2gen @ iOS 16-2.png', + 'repo/org.fake/en-US/tenInchScreenshots/iPad_Pro_12.9"_2gen_@_iOS_16-2.png', + ), + mock.call( + 'build/org.fake/fastlane/screenshots/de-DE/1_ipadPro129_1.1.png', + 'repo/org.fake/de-DE/tenInchScreenshots/1_ipadPro129_1.1.png', + ), + ], + ) + + if __name__ == "__main__": os.chdir(os.path.dirname(__file__)) @@ -2088,4 +2218,7 @@ if __name__ == "__main__": newSuite.addTest(unittest.makeSuite(UpdateTest)) newSuite.addTest(unittest.makeSuite(TestUpdateVersionStringToInt)) newSuite.addTest(unittest.makeSuite(TestScanRepoForIpas)) + newSuite.addTest(unittest.makeSuite(TestParseIosScreenShotName)) + newSuite.addTest(unittest.makeSuite(TestInsertLocalizedIosAppMetadata)) + newSuite.addTest(unittest.makeSuite(TestDiscoverIosScreenshots)) unittest.main(failfast=False) From b6482f19a65c62f33e41789b8cfa629405ba1a8b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michael=20P=C3=B6hn?= Date: Wed, 3 Apr 2024 16:48:50 +0200 Subject: [PATCH 8/8] =?UTF-8?q?=F0=9F=9B=A3=EF=B8=8F=20update:=20fix=20pat?= =?UTF-8?q?hlib=20import?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- fdroidserver/update.py | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/fdroidserver/update.py b/fdroidserver/update.py index cc97c094..5ce3f89d 100644 --- a/fdroidserver/update.py +++ b/fdroidserver/update.py @@ -34,7 +34,6 @@ import json import time import yaml import copy -import pathlib import defusedxml.ElementTree as ElementTree from datetime import datetime, timezone from argparse import ArgumentParser @@ -1299,7 +1298,7 @@ def discover_ios_screenshots(fastlane_dir): def copy_ios_screenshots_to_repo(screenshots, package_name): for locale, translated_screenshots in screenshots.items(): for device, translated_device_screenshots in translated_screenshots.items(): - dest_dir = pathlib.Path('repo') / package_name / locale / device + dest_dir = Path('repo') / package_name / locale / device dest_dir.mkdir(mode=0o755, parents=True, exist_ok=True) for path in translated_device_screenshots: dest = dest_dir / (path.name.replace(" ", "_").replace("\t", "_")) @@ -1308,17 +1307,17 @@ def copy_ios_screenshots_to_repo(screenshots, package_name): def insert_localized_ios_app_metadata(apps_with_packages): - if not any(pathlib.Path('repo').glob('*.ipa')): + if not any(Path('repo').glob('*.ipa')): # no IPA files present in repo, nothing to do here, exiting early return for package_name, app in apps_with_packages.items(): - if not any(pathlib.Path('repo').glob(f'{package_name}*.ipa')): + if not any(Path('repo').glob(f'{package_name}*.ipa')): # couldn't find any IPA files for this package_name # so we don't have to look for fastlane data continue - fastlane_dir = pathlib.Path('build', package_name, 'fastlane') + fastlane_dir = Path('build', package_name, 'fastlane') fastlane_meta_dir = (fastlane_dir / "metadata") if fastlane_meta_dir.is_dir():