mirrors/fdroidserver
1
0
Fork 0
mirror of https://github.com/f-droid/fdroidserver.git synced 2025-09-14 15:02:51 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

Avoid zero-length prefixes in PATH

Browse source 
A zero-length prefix in PATH is a legacy feature that indicates the
current working directory.

https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap08.html#tag_08_03

Found in ru.nsu.bobrofon.easysshfs, see:
https://gitlab.com/fdroid/fdroiddata/-/merge_requests/10953#note_921802636
This commit is contained in:
Sergey Bobrenok 2022-04-24 16:33:33 +03:00
parent 694050e561
commit 46f4205fff
2 changed files with 9 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
fdroidserver/common.py
View file

@ -3006,7 +3006,7 @@ def set_FDroidPopen_env(build=None):
if build is not None: if build is not None:
path = build.ndk_path() path = build.ndk_path()
paths = orig_path.split(os.pathsep) paths = orig_path.split(os.pathsep)
if path not in paths: if path and path not in paths:
paths = [path] + paths paths = [path] + paths
env['PATH'] = os.pathsep.join(paths) env['PATH'] = os.pathsep.join(paths)
for n in ['ANDROID_NDK', 'NDK', 'ANDROID_NDK_HOME']: for n in ['ANDROID_NDK', 'NDK', 'ANDROID_NDK_HOME']:

8
tests/common.TestCase
View file

@ -2364,6 +2364,14 @@ class CommonTest(unittest.TestCase):
"%s_%s.exe" % (app.id, build.versionCode), "%s_%s.exe" % (app.id, build.versionCode),
) )
def test_no_zero_length_ndk_path_prefixes(self):
fdroidserver.common.config = {'ndk_paths': {}}
build = fdroidserver.metadata.Build()
os.environ['PATH'] = '/usr/bin:/usr/sbin'
fdroidserver.common.set_FDroidPopen_env(build)
self.assertNotIn('', os.getenv('PATH').split(os.pathsep))
if __name__ == "__main__": if __name__ == "__main__":
os.chdir(os.path.dirname(__file__)) os.chdir(os.path.dirname(__file__))