mirrors/fdroidserver
1
0
Fork 0
mirror of https://github.com/f-droid/fdroidserver.git synced 2025-09-15 15:32:30 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge branch 'close-subprocess-file-handles' into 'master'

Browse source 
make sure file-streams of subprocesses get closed

See merge request !328
This commit is contained in:
Hans-Christoph Steiner 2017-09-07 09:49:51 +00:00
commit 3aee9b3f11
1 changed files with 6 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

6
fdroidserver/common.py
View file

@ -1804,6 +1804,12 @@ def FDroidPopenBytes(commands, cwd=None, envs=None, output=True, stderr_to_stdou
result.returncode = p.wait() result.returncode = p.wait()
result.output = buf.getvalue() result.output = buf.getvalue()
buf.close() buf.close()
# make sure all filestreams of the subprocess are closed
for streamvar in ['stdin', 'stdout', 'stderr']:
if hasattr(p, streamvar):
stream = getattr(p, streamvar)
if stream:
stream.close()
return result return result