mirrors/fdroidserver
1
0
Fork 0
mirror of https://github.com/f-droid/fdroidserver.git synced 2025-11-05 15:00:30 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

Warn about unknown licenses, some extra link checks

Browse source
This commit is contained in:
Daniel Martí 2014-01-20 11:34:39 +01:00
parent e7b863ad20
commit 2f5b029d97
1 changed files with 13 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

16
fdroidserver/lint.py
View file

@ -50,7 +50,15 @@ def main():
apps = common.read_app_args(args, allapps, False) apps = common.read_app_args(args, allapps, False)
regex_warnings = { regex_warnings = {
'Web Site': [
(re.compile(r'.*github\.com/[^/]+/[^/]+\.git'),
"Appending .git is not necessary"),
(re.compile(r'.*code\.google\.com/p/[^/]+/[^w]'),
"Possible incorrect path appended to google code project site")
],
'Source Code': [ 'Source Code': [
(re.compile(r'.*github\.com/[^/]+/[^/]+\.git'),
"Appending .git is not necessary"),
(re.compile(r'.*code\.google\.com/p/[^/]+/source/.*'), (re.compile(r'.*code\.google\.com/p/[^/]+/source/.*'),
"/source is often enough on its own"), "/source is often enough on its own"),
(re.compile(r'.*code\.google\.com/p/[^/]+[/]*$'), (re.compile(r'.*code\.google\.com/p/[^/]+[/]*$'),
@ -81,6 +89,10 @@ def main():
any(s in lastcommit for s in ('.', ',', '_', '-', '/'))): any(s in lastcommit for s in ('.', ',', '_', '-', '/'))):
warn("Last used commit '%s' looks like a tag, but Update Check Mode is RepoManifest" % lastcommit) warn("Last used commit '%s' looks like a tag, but Update Check Mode is RepoManifest" % lastcommit)
# No license
if app['License'] == 'Unknown':
warn("License was not properly set")
# Summary size limit # Summary size limit
summ_chars = len(app['Summary']) summ_chars = len(app['Summary'])
if summ_chars > config['char_limits']['Summary']: if summ_chars > config['char_limits']['Summary']:
@ -104,9 +116,7 @@ def main():
warn("Summary should not end with a %s" % lastchar) warn("Summary should not end with a %s" % lastchar)
# Common mistakes in urls # Common mistakes in urls
for f in ['Source Code', 'Issue Tracker']: for f in regex_warnings:
if f not in regex_warnings:
continue
for m, r in regex_warnings[f]: for m, r in regex_warnings[f]:
if m.match(app[f]): if m.match(app[f]):
warn("%s url '%s': %s" % (f, app[f], r)) warn("%s url '%s': %s" % (f, app[f], r))