mirrors/fdroidserver
1
0
Fork 0
mirror of https://github.com/f-droid/fdroidserver.git synced 2025-11-04 14:30:30 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

ban apksigner v33, it has bugs verifying APKs with v3/v3.1 sigs

Browse source
This commit is contained in:
Hans-Christoph Steiner 2025-01-21 15:00:23 +00:00
parent afd1a89ca5
commit 2ac925a249
3 changed files with 61 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

49
tests/test_common.py
View file

@ -3282,6 +3282,55 @@ class SignerExtractionTest(unittest.TestCase):
)
class IgnoreApksignerV33Test(CommonTest):
"""apksigner v33 should be entirely ignored
https://gitlab.com/fdroid/fdroidserver/-/issues/1253
"""
BAD_VERSIONS = [
'33.0.0-rc1',
'33.0.0-rc2',
'33.0.0-rc3',
'33.0.0-rc4',
'33.0.0',
'33.0.1',
'33.0.2',
'33.0.3',
]
def setUp(self):
super().setUp()
self.config = {'sdk_path': self.testdir}
def _create_fake_build_tools(self, version):
for v in self.BAD_VERSIONS + [version]:
apksigner = os.path.join(self.testdir, 'build-tools', v, 'apksigner')
os.makedirs(os.path.dirname(apksigner))
with open(apksigner, 'w') as fp:
fp.write(f'#!/bin/sh\necho {v}[\n')
os.chmod(apksigner, 0o0755) # nosec B103
def test_find_apksigner_choose_version_32_over_any_33(self):
good = '32.0.0'
self._create_fake_build_tools(good)
with mock.patch.dict(os.environ, clear=True):
os.environ['PATH'] = '/fake/path/to/avoid/conflicts'
fdroidserver.common.find_apksigner(self.config)
self.assertEqual(
os.path.join(self.testdir, 'build-tools', good, 'apksigner'),
self.config.get('apksigner'),
)
def test_find_apksigner_choose_no_version_over_any_33(self):
"""apksigner v33 should be entirely ignored"""
self._create_fake_build_tools('29.0.0') # too old a version
with mock.patch.dict(os.environ, clear=True):
os.environ['PATH'] = '/fake/path/to/avoid/conflicts'
fdroidserver.common.find_apksigner(self.config)
self.assertIsNone(self.config.get('apksigner'))
class ConfigOptionsScopeTest(unittest.TestCase):
"""Test assumptions about variable scope for "config" and "options".