mirror of
				https://github.com/f-droid/fdroidserver.git
				synced 2025-11-04 06:30:27 +03:00 
			
		
		
		
	added test case for common.isApkDebuggable()
Just getting into the habit of adding tests to everything that I change... Also, it should be useful to have an unsigned APK in the test collection, since `fdroid update` should handle it gracefully and give a warning of some kind.
This commit is contained in:
		
							parent
							
								
									f7c9eccc1f
								
							
						
					
					
						commit
						298a88a498
					
				
					 4 changed files with 55 additions and 0 deletions
				
			
		
							
								
								
									
										54
									
								
								tests/common.TestCase
									
										
									
									
									
										Executable file
									
								
							
							
						
						
									
										54
									
								
								tests/common.TestCase
									
										
									
									
									
										Executable file
									
								
							| 
						 | 
				
			
			@ -0,0 +1,54 @@
 | 
			
		|||
#!/usr/bin/env python2
 | 
			
		||||
# -*- coding: utf-8 -*-
 | 
			
		||||
 | 
			
		||||
# http://www.drdobbs.com/testing/unit-testing-with-python/240165163
 | 
			
		||||
 | 
			
		||||
import inspect
 | 
			
		||||
import optparse
 | 
			
		||||
import os
 | 
			
		||||
import sys
 | 
			
		||||
import unittest
 | 
			
		||||
 | 
			
		||||
localmodule = os.path.realpath(os.path.join(
 | 
			
		||||
        os.path.dirname(inspect.getfile(inspect.currentframe())),
 | 
			
		||||
        '..'))
 | 
			
		||||
print('localmodule: ' + localmodule)
 | 
			
		||||
if localmodule not in sys.path:
 | 
			
		||||
    sys.path.insert(0,localmodule)
 | 
			
		||||
 | 
			
		||||
import fdroidserver.common
 | 
			
		||||
 | 
			
		||||
class CommonTest(unittest.TestCase):
 | 
			
		||||
    '''fdroidserver/common.py'''
 | 
			
		||||
 | 
			
		||||
    def testIsApkDebuggable(self):
 | 
			
		||||
        config = dict()
 | 
			
		||||
        config['aapt'] = '/usr/bin/aapt'
 | 
			
		||||
        # these are set debuggable
 | 
			
		||||
        testfiles = []
 | 
			
		||||
        testfiles.append(os.path.join(os.path.dirname(__file__), 'urzip.apk'))
 | 
			
		||||
        testfiles.append(os.path.join(os.path.dirname(__file__), 'urzip-badsig.apk'))
 | 
			
		||||
        testfiles.append(os.path.join(os.path.dirname(__file__), 'urzip-badcert.apk'))
 | 
			
		||||
        for apkfile in testfiles:
 | 
			
		||||
            debuggable = fdroidserver.common.isApkDebuggable(apkfile, config)
 | 
			
		||||
            self.assertTrue(debuggable,
 | 
			
		||||
                            "debuggable APK state was not properly parsed!")
 | 
			
		||||
        # these are set NOT debuggable
 | 
			
		||||
        testfiles = []
 | 
			
		||||
        testfiles.append(os.path.join(os.path.dirname(__file__), 'urzip-release.apk'))
 | 
			
		||||
        testfiles.append(os.path.join(os.path.dirname(__file__), 'urzip-release-unsigned.apk'))
 | 
			
		||||
        for apkfile in testfiles:
 | 
			
		||||
            debuggable = fdroidserver.common.isApkDebuggable(apkfile, config)
 | 
			
		||||
            self.assertFalse(debuggable,
 | 
			
		||||
                             "debuggable APK state was not properly parsed!")
 | 
			
		||||
 | 
			
		||||
 | 
			
		||||
if __name__ == "__main__":
 | 
			
		||||
    parser = optparse.OptionParser()
 | 
			
		||||
    parser.add_option("-v", "--verbose", action="store_true", default=False,
 | 
			
		||||
                      help="Spew out even more information than normal")
 | 
			
		||||
    (fdroidserver.common.options, args) = parser.parse_args(['--verbose'])
 | 
			
		||||
 | 
			
		||||
    newSuite = unittest.TestSuite()
 | 
			
		||||
    newSuite.addTest(unittest.makeSuite(CommonTest))
 | 
			
		||||
    unittest.main()
 | 
			
		||||
| 
						 | 
				
			
			@ -98,6 +98,7 @@ echo_header "test python getsig replacement"
 | 
			
		|||
cd $WORKSPACE/tests/getsig
 | 
			
		||||
./make.sh
 | 
			
		||||
cd $WORKSPACE/tests
 | 
			
		||||
./common.TestCase
 | 
			
		||||
./update.TestCase
 | 
			
		||||
 | 
			
		||||
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
							
								
								
									
										
											BIN
										
									
								
								tests/urzip-release-unsigned.apk
									
										
									
									
									
										Normal file
									
								
							
							
						
						
									
										
											BIN
										
									
								
								tests/urzip-release-unsigned.apk
									
										
									
									
									
										Normal file
									
								
							
										
											Binary file not shown.
										
									
								
							
							
								
								
									
										
											BIN
										
									
								
								tests/urzip-release.apk
									
										
									
									
									
										Normal file
									
								
							
							
						
						
									
										
											BIN
										
									
								
								tests/urzip-release.apk
									
										
									
									
									
										Normal file
									
								
							
										
											Binary file not shown.
										
									
								
							
		Loading…
	
	Add table
		Add a link
		
	
		Reference in a new issue