mirrors/fdroidserver
1
0
Fork 0
mirror of https://github.com/f-droid/fdroidserver.git synced 2025-09-14 23:12:46 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

remove aapt version of common.is_apk_and_debuggable()

Browse source
This commit is contained in:
Hans-Christoph Steiner 2020-10-14 16:49:00 +02:00
parent b5cd850abe
commit 27b90a13bf
2 changed files with 9 additions and 46 deletions
Download patch file Download diff file Expand all files Collapse all files

32
fdroidserver/common.py
View file

@ -2389,19 +2389,15 @@ def ensure_final_value(packageName, arsc, value):
return ''
def is_apk_and_debuggable_aapt(apkfile):
p = SdkToolsPopen(['aapt', 'dump', 'xmltree', apkfile, 'AndroidManifest.xml'],
output=False)
if p.returncode != 0:
raise FDroidException(_("Failed to get APK manifest information"))
for line in p.output.splitlines():
if 'android:debuggable' in line and not line.endswith('0x0'):
return True
return False
def is_apk_and_debuggable(apkfile):
"""Returns True if the given file is an APK and is debuggable
Parse only <application android:debuggable=""> from the APK.
def is_apk_and_debuggable_androguard(apkfile):
"""Parse only <application android:debuggable=""> from the APK"""
:param apkfile: full path to the apk to check"""
if get_file_extension(apkfile) != 'apk':
return False
from androguard.core.bytecodes.axml import AXMLParser, format_value, START_TAG
with ZipFile(apkfile) as apk:
with apk.open('AndroidManifest.xml') as manifest:
@ -2423,20 +2419,6 @@ def is_apk_and_debuggable_androguard(apkfile):
return False
def is_apk_and_debuggable(apkfile):
"""Returns True if the given file is an APK and is debuggable
:param apkfile: full path to the apk to check"""
if get_file_extension(apkfile) != 'apk':
return False
if use_androguard():
return is_apk_and_debuggable_androguard(apkfile)
else:
return is_apk_and_debuggable_aapt(apkfile)
def get_apk_id(apkfile):
"""Extract identification information from APK.