From 1fbfae355a3831bd55a2b02882c8d96f8a2dc415 Mon Sep 17 00:00:00 2001 From: Hans-Christoph Steiner Date: Mon, 20 Mar 2023 15:05:34 +0100 Subject: [PATCH] pylint: Reenable R1723 no-else-break * R1723: Unnecessary "elif" after "break", remove the leading "el" from "elif" (no-else-break) --- fdroidserver/common.py | 2 +- fdroidserver/deploy.py | 2 +- pyproject.toml | 1 - 3 files changed, 2 insertions(+), 3 deletions(-) diff --git a/fdroidserver/common.py b/fdroidserver/common.py index aacbb7bf..942e8fe6 100644 --- a/fdroidserver/common.py +++ b/fdroidserver/common.py @@ -1803,7 +1803,7 @@ def parse_androidmanifests(paths, app): if re.match(r'.*[\'"\s]{flavour}[\'"\s].*\{{.*'.format(flavour=flavour), line): inside_required_flavour = 2 break - elif re.match(r'.*[\'"\s]{flavour}[\'"\s].*'.format(flavour=flavour), line): + if re.match(r'.*[\'"\s]{flavour}[\'"\s].*'.format(flavour=flavour), line): inside_required_flavour = 1 break diff --git a/fdroidserver/deploy.py b/fdroidserver/deploy.py index 06509db3..0415f7f4 100644 --- a/fdroidserver/deploy.py +++ b/fdroidserver/deploy.py @@ -623,7 +623,7 @@ def upload_apk_to_virustotal(virustotal_apikey, packageName, apkName, hash, + str(response['positives']) + ' times:' + '\n\t' + response['permalink']) break - elif r.status_code == 204: + if r.status_code == 204: logging.warning(_('virustotal.com is rate limiting, waiting to retry...')) time.sleep(30) # wait for public API rate limiting diff --git a/pyproject.toml b/pyproject.toml index a3a1dda2..77104a0f 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -67,7 +67,6 @@ disable = [ "missing-class-docstring", "missing-function-docstring", "missing-module-docstring", - "no-else-break", "no-else-continue", "no-else-raise", "no-else-return",