mirror of
https://github.com/f-droid/fdroidserver.git
synced 2025-11-04 22:40:29 +03:00
lint can no longer properly detect unset Summary/Description
Since the Summary/Description can now be set in the app's source code, or in fdroiddata/metadata/<packageName>/<locale>/*.txt, this lint check is no longer valid. It is important to check whether these texts are empty, but it'll require some thinking about how and where to best to that. `fdroid update` will have access to all that data, but perhaps at that point it is too late. Also, the current text prioritization puts Summary/Description in the .txt/.yml file at the highest priority, overriding every other copy, including in fdroiddata/metadata/<packageName>/<locale> and in the app's source code.
This commit is contained in:
parent
37c3bf304c
commit
18c3bfa5fb
1 changed files with 0 additions and 4 deletions
|
|
@ -88,8 +88,6 @@ regex_checks = {
|
||||||
"Unnecessary trailing space"),
|
"Unnecessary trailing space"),
|
||||||
],
|
],
|
||||||
'Summary': [
|
'Summary': [
|
||||||
(re.compile(r'^$'),
|
|
||||||
"Summary yet to be filled"),
|
|
||||||
(re.compile(r'.*\b(free software|open source)\b.*', re.IGNORECASE),
|
(re.compile(r'.*\b(free software|open source)\b.*', re.IGNORECASE),
|
||||||
"No need to specify that the app is Free Software"),
|
"No need to specify that the app is Free Software"),
|
||||||
(re.compile(r'.*((your|for).*android|android.*(app|device|client|port|version))', re.IGNORECASE),
|
(re.compile(r'.*((your|for).*android|android.*(app|device|client|port|version))', re.IGNORECASE),
|
||||||
|
|
@ -102,8 +100,6 @@ regex_checks = {
|
||||||
"Unnecessary trailing space"),
|
"Unnecessary trailing space"),
|
||||||
],
|
],
|
||||||
'Description': [
|
'Description': [
|
||||||
(re.compile(r'^No description available$'),
|
|
||||||
"Description yet to be filled"),
|
|
||||||
(re.compile(r'\s*[*#][^ .]'),
|
(re.compile(r'\s*[*#][^ .]'),
|
||||||
"Invalid bulleted list"),
|
"Invalid bulleted list"),
|
||||||
(re.compile(r'^\s'),
|
(re.compile(r'^\s'),
|
||||||
|
|
|
||||||
Loading…
Add table
Add a link
Reference in a new issue