From 153b5d43929f4094414dd7388c5c8a6512f91aaf Mon Sep 17 00:00:00 2001 From: Hans-Christoph Steiner Date: Fri, 28 May 2021 10:21:52 +0200 Subject: [PATCH] stop modifying default_config when running fill_config_defaults() dicts and lists are passed by reference in assignments, so this needs to copy them instead. --- fdroidserver/common.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/fdroidserver/common.py b/fdroidserver/common.py index 851fdea5..4af0595f 100644 --- a/fdroidserver/common.py +++ b/fdroidserver/common.py @@ -224,7 +224,10 @@ def fill_config_defaults(thisconfig): """ for k, v in default_config.items(): if k not in thisconfig: - thisconfig[k] = v + if isinstance(v, dict) or isinstance(v, list): + thisconfig[k] = v.copy() + else: + thisconfig[k] = v # Expand paths (~users and $vars) def expand_path(path):