mirrors/fdroidserver
1
0
Fork 0
mirror of https://github.com/f-droid/fdroidserver.git synced 2025-11-06 07:20:29 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

A couple more rules for lint

Browse source
This commit is contained in:
Daniel Martí 2014-03-18 12:26:24 +01:00
parent f8805d88ae
commit 03975808a3
1 changed files with 7 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

13
fdroidserver/lint.py
View file

@ -106,6 +106,8 @@ regex_pedantic = {
"No need to specify that the app is... an app"), "No need to specify that the app is... an app"),
(re.compile(r'.*\b(free software|open source)\b.*', re.IGNORECASE), (re.compile(r'.*\b(free software|open source)\b.*', re.IGNORECASE),
"No need to specify that the app is Free Software"), "No need to specify that the app is Free Software"),
(re.compile(r'.*[.,!?].*'),
"Punctuation should be avoided"),
], ],
} }
@ -180,12 +182,6 @@ def main():
warn("Description of length %s is over the %i char limit" % ( warn("Description of length %s is over the %i char limit" % (
desc_chars, config['char_limits']['Description'])) desc_chars, config['char_limits']['Description']))
# No punctuation in summary
if app['Summary']:
lastchar = app['Summary'][-1]
if any(lastchar==c for c in '.,!?'):
warn("Summary should not end with a %s" % lastchar)
# Regex checks in all kinds of fields # Regex checks in all kinds of fields
for f in regex_warnings: for f in regex_warnings:
for m, r in regex_warnings[f]: for m, r in regex_warnings[f]:
@ -205,6 +201,11 @@ def main():
if 'commit' in build: if 'commit' in build:
if build['commit'].startswith(n): if build['commit'].startswith(n):
warn("Branch '%s' used as commit" % n) warn("Branch '%s' used as commit" % n)
if 'srclibs' in build:
for srclib in build['srclibs']:
ref = srclib.split('@')[1].split('/')[0]
if ref.startswith(n):
warn("Branch '%s' used as srclib commit" % n)
if not appid: if not appid:
print print