From 007c62065d25dcd94e1ef74a11b888223c706dc8 Mon Sep 17 00:00:00 2001 From: Hans-Christoph Steiner Date: Fri, 12 Feb 2021 10:51:26 +0100 Subject: [PATCH] pylint flags "_" as bad variable name, its the gettext function Throughout the fdroidserver code base, "_()" is used for localizing strings. So it should not be used as an ignored variable name. Those should be called "_ignored". --- .pylint-rcfile | 2 +- fdroidserver/index.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.pylint-rcfile b/.pylint-rcfile index 4685d7f4..8cc4c8d8 100644 --- a/.pylint-rcfile +++ b/.pylint-rcfile @@ -35,7 +35,7 @@ notes=FIXME,XXX,TODO [BASIC] # Good variable names which should always be accepted, separated by a comma -good-names=i,j,k,ex,Run,_,e,f,fp +good-names=i,j,k,ex,Run,f,fp [ELIF] diff --git a/fdroidserver/index.py b/fdroidserver/index.py index f9120bd8..78dd9ef1 100644 --- a/fdroidserver/index.py +++ b/fdroidserver/index.py @@ -142,7 +142,7 @@ def _should_file_be_generated(path, magic_string): def make_website(apps, repodir, repodict): - _, repo_pubkey_fingerprint = extract_pubkey() + _ignored, repo_pubkey_fingerprint = extract_pubkey() repo_pubkey_fingerprint_stripped = repo_pubkey_fingerprint.replace(" ", "") link = repodict["address"] link_fingerprinted = "{link}?fingerprint={fingerprint}".format(link=link, fingerprint=repo_pubkey_fingerprint_stripped)