From adc3db16311773037f26e9cd19cc1cff6b240d7b Mon Sep 17 00:00:00 2001 From: Ajay Bura <32841439+ajbura@users.noreply.github.com> Date: Thu, 14 Aug 2025 12:11:40 +0530 Subject: [PATCH] consider creators in guessing perfect parent --- src/app/utils/room.ts | 44 +++++++++++++++++++++++++++++++++++++------ 1 file changed, 38 insertions(+), 6 deletions(-) diff --git a/src/app/utils/room.ts b/src/app/utils/room.ts index a962c45d..b4bba2ad 100644 --- a/src/app/utils/room.ts +++ b/src/app/utils/room.ts @@ -20,6 +20,7 @@ import { import { CryptoBackend } from 'matrix-js-sdk/lib/common-crypto/CryptoBackend'; import { AccountDataEvent } from '../../types/matrix/accountData'; import { + IRoomCreateContent, Membership, MessageEvent, NotificationType, @@ -43,7 +44,7 @@ export const getStateEvents = (room: Room, eventType: StateEvent): MatrixEvent[] export const getAccountData = ( mx: MatrixClient, eventType: AccountDataEvent -): MatrixEvent | undefined => mx.getAccountData(eventType); +): MatrixEvent | undefined => mx.getAccountData(eventType as any); export const getMDirects = (mDirectEvent: MatrixEvent): Set => { const roomIds = new Set(); @@ -480,6 +481,23 @@ export const bannedInRooms = (mx: MatrixClient, rooms: string[], otherUserId: st return banned; }); +export const getAllVersionsRoomCreator = (room: Room): Set => { + const creators = new Set(); + + const createEvent = getStateEvent(room, StateEvent.RoomCreate); + const createContent = createEvent?.getContent(); + const creator = createEvent?.getSender(); + if (typeof creator === 'string') creators.add(creator); + + if (createContent && Array.isArray(createContent.additional_creators)) { + createContent.additional_creators.forEach((c) => { + if (typeof c === 'string') creators.add(c); + }); + } + + return creators; +}; + export const guessPerfectParent = ( mx: MatrixClient, roomId: string, @@ -490,15 +508,29 @@ export const guessPerfectParent = ( } const getSpecialUsers = (rId: string): string[] => { + const specialUsers: Set = new Set(); + const r = mx.getRoom(rId); - const powerLevels = - r && getStateEvent(r, StateEvent.RoomPowerLevels)?.getContent(); + if (!r) return []; + + getAllVersionsRoomCreator(r).forEach((c) => specialUsers.add(c)); + + const powerLevels = getStateEvent( + r, + StateEvent.RoomPowerLevels + )?.getContent(); const { users_default: usersDefault, users } = powerLevels ?? {}; - if (typeof users !== 'object') return []; - const defaultPower = typeof usersDefault === 'number' ? usersDefault : 0; - return Object.keys(users).filter((userId) => users[userId] > defaultPower); + + if (typeof users === 'object') + Object.keys(users).forEach((userId) => { + if (users[userId] > defaultPower) { + specialUsers.add(userId); + } + }); + + return Array.from(specialUsers); }; let perfectParent: string | undefined;