mirrors/cinny
1
0
Fork 0
mirror of https://github.com/cinnyapp/cinny.git synced 2025-11-05 06:50:28 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix rate limit when reordering in space lobby (#2254)

Browse source 
* move can drop lobby item logic to hook

* add comment

* resolve rate limit when reordering space children
This commit is contained in:
Ajay Bura 2025-05-26 14:21:27 +05:30 • committed by GitHub
parent 83057ebbd4
commit a23279e633
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 270 additions and 187 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/app/features/lobby/SpaceHierarchy.tsx
View file

@ -31,6 +31,7 @@ type SpaceHierarchyProps = {
draggingItem?: HierarchyItem;
onDragging: (item?: HierarchyItem) => void;
canDrop: CanDropCallback;
disabledReorder?: boolean;
nextSpaceId?: string;
getRoom: (roomId: string) => Room | undefined;
pinned: boolean;
@ -54,6 +55,7 @@ export const SpaceHierarchy = forwardRef<HTMLDivElement, SpaceHierarchyProps>(
draggingItem,
onDragging,
canDrop,
disabledReorder,
nextSpaceId,
getRoom,
pinned,
@ -116,7 +118,9 @@ export const SpaceHierarchy = forwardRef<HTMLDivElement, SpaceHierarchyProps>(
handleClose={handleClose}
getRoom={getRoom}
canEditChild={canEditSpaceChild(spacePowerLevels)}
canReorder={parentPowerLevels ? canEditSpaceChild(parentPowerLevels) : false}
canReorder={
parentPowerLevels && !disabledReorder ? canEditSpaceChild(parentPowerLevels) : false
}
options={
parentId &&
parentPowerLevels && (
@ -174,7 +178,7 @@ export const SpaceHierarchy = forwardRef<HTMLDivElement, SpaceHierarchyProps>(
dm={mDirects.has(roomItem.roomId)}
onOpen={onOpenRoom}
getRoom={getRoom}
canReorder={canEditSpaceChild(spacePowerLevels)}
canReorder={canEditSpaceChild(spacePowerLevels) && !disabledReorder}
options={
<HierarchyItemMenu
item={roomItem}